Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LocProject.json to eng folder #7412

Merged
merged 2 commits into from
May 19, 2021

Conversation

jonfortescue
Copy link
Member

@jonfortescue jonfortescue commented May 19, 2021

Closes dotnet/core-eng#12894.

Winforms asked very nicely and it was an easy change so I did it. Working test builds here and here.

NFT for this commit can be purchased here.

To double check:

@jonfortescue jonfortescue self-assigned this May 19, 2021
Copy link
Member

@garath garath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in chat: Jon wants to make a doc update to go with this.

@jonfortescue
Copy link
Member Author

@garath one line in docs added!

@jonfortescue jonfortescue merged commit 30a24ac into dotnet:main May 19, 2021
@jonfortescue jonfortescue deleted the LocProjectEngFolder branch May 19, 2021 22:05
@RussKie
Copy link
Member

RussKie commented May 19, 2021

Champion! Thank you

RussKie added a commit to RussKie/winforms that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants