Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Devops Reporter : new change assumes Python 3.6+ #7438

Merged
merged 3 commits into from
May 25, 2021
Merged

Fix Azure Devops Reporter : new change assumes Python 3.6+ #7438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3a7d45
It seems we don't test this codepath in default test runs, and the me…
MattGal May 24, 2021
2ace615
Add expected-to-fail test to exercise failure reporting path
MattGal May 24, 2021
45d9850
New approach; specify a failure test result with all the bad characte…
MattGal May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/formats/xunit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def bs(match):
sym = grp[1]
if sym == 'x':
return chr(int(grp[2:], 16))
return _unescape_char_map.get(match[0][1]) or sym
return _unescape_char_map.get(match.group(0)[1]) or sym
return re.sub(r'\\x[0-9a-fA-F][0-9a-fA-F][0-9a-fA-F]?[0-9a-fA-F]?|\\[^x]', bs, value)

class XUnitFormat(ResultFormat):
Expand Down
11 changes: 11 additions & 0 deletions tests/UnitTests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,17 @@
<XUnitProject Remove="..\src\Microsoft.DotNet.Build.Tasks.VisualStudio.Tests\Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj"/>
</ItemGroup>

<ItemGroup>
<HelixWorkItem Include="FailingXUnitTestsTest">
<Command>echo 'done!'</Command>
<PayloadDirectory>$(MSBuildThisFileDirectory)XUnit</PayloadDirectory>
</HelixWorkItem>
</ItemGroup>
<!-- Exercise Helix failure reporting path for Xunit -->
<ItemGroup>
<AzurePipelinesExpectedTestFailure Include="XunitReportingTests.ExerciseXunitCharacterFilteringFailurePath"/>
</ItemGroup>

<ItemGroup Condition=" '$(HelixAccessToken)' != '' ">
<HelixTargetQueue Include="Debian.9.Amd64"/>
<HelixTargetQueue Include="RedHat.7.Amd64"/>
Expand Down
14 changes: 14 additions & 0 deletions tests/XUnit/testResults.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<assemblies timestamp="05/24/2021 16:33:36">
<assembly name="SomeXUnitTests.DLL" total="1" passed="0" failed="1" skipped="0" time="0.435" errors="0">
<errors />
<collection total="1" passed="0" failed="1" skipped="0" name="Test collection for XunitReportingTests" time="0.056">
<test name="XunitReportingTests.ExerciseXunitCharacterFilteringFailurePath" type="XunitReportingTests" method="ExerciseXunitCharacterFilteringFailurePath" time="0.0564499" result="Fail">
<failure exception-type="Xunit.Sdk.TrueException">
<message><![CDATA[Intentional Failure 🍕 \r \n \t \a \b \v \f \0\r\nExpected: True\r\nActual: False]]></message>
<stack-trace><![CDATA[ at XunitReportingTests.ExerciseXunitCharacterFilteringFailurePath() in Class1.cs:line 1]]></stack-trace>
</failure>
</test>
</collection>
</assembly>
</assemblies>