Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting multiple targets in XHarness Helix SDK #7462

Merged
merged 7 commits into from
Jun 3, 2021

Conversation

premun
Copy link
Member

@premun premun commented Jun 2, 2021

We never supported this really and it was deprecated in dotnet/xharness#618

This will be a breaking change in the SDK:

<Targets>ios-simulator-64</Targets>

will change to

<TestTarget>ios-simulator-64</TestTarget>

@premun
Copy link
Member Author

premun commented Jun 2, 2021

@akoeplinger we could make it a non-breaking change but I assume it will be trivial to change in the dependency update PR?

What do you think?

@akoeplinger
Copy link
Member

@premun should be fine. Did you talk to Manuel about removing the multi-target option from xharness? Not sure if they used it on their end.

@premun
Copy link
Member Author

premun commented Jun 3, 2021

@akoeplinger they are actually only using the Microsoft.DotNet.XHarness.iOS.Shared nuget and have their own sort of CLI on top of it:
https://github.com/xamarin/xamarin-macios/tree/main/tests/xharness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants