Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoremvidmismatch option in ibcmerge #7599

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

genlu
Copy link
Member

@genlu genlu commented Jul 7, 2021

Address the ibcmerge mismatch MVID error encountered in Roslyn build
dotnet/roslyn#53197

The new switch is added in https://devdiv.visualstudio.com/DevDiv/_git/DotNet-IbcMerge/pullrequest/335636

FYI @JoeRobich

@genlu genlu requested review from tmat and davidwrighton July 7, 2021 18:23
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@genlu
Copy link
Member Author

genlu commented Jul 7, 2021

@davidwrighton @tmat Is there a way to validate this change before hitting merge?

@genlu genlu merged commit 189395d into dotnet:main Jul 8, 2021
@genlu genlu deleted the ibcmergeIgnore branch July 8, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants