Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s390x rootfs build #7609

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix s390x rootfs build #7609

merged 1 commit into from
Jul 12, 2021

Conversation

janvorli
Copy link
Member

Ubuntu for s390x architecture doesn't have OMP libraries. Remove them from rootfs build for s390x. Support for this architecture is in a very experimental stage and the OMP is needed for ML .NET only.

@janvorli
Fix s390x rootfs build
36b6d6d 
Ubuntu for s390x architecture doesn't have OMP libraries.
@janvorli janvorli self-assigned this Jul 12, 2021
@janvorli
Copy link
Member Author

The Linux leg failure is unrelated to this change. It seems that it is trying to use image that was recently removed. @mthalman is that one of those?

2021-07-12T11:34:45.8207074Z ##[command]/usr/bin/docker network prune --force --filter "label=b93516"
2021-07-12T11:34:45.9350721Z ##[command]/usr/bin/docker pull microsoft/dotnet-buildtools-prereqs:ubuntu-14.04-cross-0cd4667-20170319080304
2021-07-12T11:34:46.3766430Z Error response from daemon: pull access denied for microsoft/dotnet-buildtools-prereqs, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

@janvorli
Copy link
Member Author

Ah, I can see that a pending PR #7608 is fixing that issue.

michaelgsharp
michaelgsharp approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@janvorli janvorli closed this Jul 12, 2021
@janvorli janvorli reopened this Jul 12, 2021
@janvorli janvorli merged commit b59fb36 into dotnet:main Jul 12, 2021
@janvorli janvorli deleted the fix-s390x-rootfs-build branch July 12, 2021 20:07
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgsharp michaelgsharp michaelgsharp approved these changes

Assignees

@janvorli janvorli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janvorli @michaelgsharp