Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation for library and template packs #7651

Merged
merged 4 commits into from
Jul 22, 2021

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jul 21, 2021

Ensure that library and template packs install directly under the root folder, e.g. dotnet\library-packs (no versioned sub-folders)

@pjcollins
Copy link
Member

The only other thing I can think of here is related to dotnet/sdk#17438. The template packs we produce and publish are camel-cased, however dotnet workload install foo does install fully lower-cased template packs into the template-packs folder. This may not matter for the Windows only .msi scenario but it may by worth considering doing the same thing with .msi based installs.

@joeloff
Copy link
Member Author

joeloff commented Jul 21, 2021

camel casing won't impact the MSIs, but we do use the package IDs when creating folders. More importantly, the IDs participate in generating some of the GUIDs. For the most part its fine, except in the case of manifests where the MSIs have to be upgradable, so any change in casing could break that.

@joeloff joeloff merged commit 6224d1b into dotnet:main Jul 22, 2021
@joeloff joeloff deleted the workloads11 branch July 22, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants