Retry feed artifact download on SocketException #7736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riarenas
approved these changes
Aug 10, 2021
|
It's worth noting that this change needs a follow-up where we update the arcade version used by arcade's main branch for the promotion pipeline to start reflecting this retry. |
ChadNedzlek
reviewed
Aug 10, 2021
| @@ -955,7 +956,7 @@ public async Task<string> GetContainerIdAsync(HttpClient client, ArtifactName ar | |||
|
|
|||
| return true; | |||
| } | |||
| catch (Exception toStore) when (toStore is HttpRequestException || toStore is TaskCanceledException) | |||
| catch (Exception toStore) when (toStore is HttpRequestException || toStore is TaskCanceledException || toStore is SocketException) | |||
There was a problem hiding this comment.
What exception do we not want to catch? Could we just... catch them all?
epananth
approved these changes
Aug 10, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the periodic download failure reported in dotnet/core-eng#13952 by having the download method retry on SocketException.
I was unable to create a repro to test this change or find a better one. However the logging shows that the force-close should be throwing a SocketException, which is not included in the types of Exceptions that the Download method will retry. So adding it here seems like the best choice.
I've also created a small dashboard in Grafana [here] to track occurrences. We can use it to track behavior as this change is rolled out.