Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip .NETFramework tfms #7863

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Don't strip .NETFramework tfms #7863

merged 1 commit into from
Sep 10, 2021

Conversation

ViktorHofer
Copy link
Member

With dotnet/runtime#58558, .NETFramework tfms which include a RID (i.e. net461-windows) aren't used and supported in dotnet/runtime anymore. Removing the support from the TargetFramework.Sdk as .NETFramework tfms with a RID aren't supported by NuGet anyways and throw.

To double check:

With dotnet/runtime#58558, .NETFramework tfms which include a RID (i.e. net461-windows) aren't used and supported in dotnet/runtime anymore. Removing the support from the TargetFramework.Sdk as .NETFramework tfms with a RID aren't supported by NuGet anyways and throw.
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait to merge this until your change is in on dotnet/runtime side. I'm also assuming you tested this in dotnet/runtime to ensure there are no stragglers using this.

@ViktorHofer ViktorHofer merged commit 0b38c9e into main Sep 10, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch September 10, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants