Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets #7878

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets #7878

merged 2 commits into from
Sep 10, 2021

Conversation

ViktorHofer
Copy link
Member

To double check:

@ViktorHofer
Don't strip .NETFramework tfms
b5cb084 
With dotnet/runtime#58558, .NETFramework tfms which include a RID (i.e. net461-windows) aren't used and supported in dotnet/runtime anymore. Removing the support from the TargetFramework.Sdk as .NETFramework tfms with a RID aren't supported by NuGet anyways and throw.
@ViktorHofer
Update Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets
709fe2b
Base automatically changed from ViktorHofer-patch-1 to main September 10, 2021 09:30
@ViktorHofer ViktorHofer merged commit 68b7bb8 into main Sep 10, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-3 branch September 10, 2021 20:57
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anipik Anipik Anipik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @Anipik