Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExponentialRetry to FindDotNetCliPackage task #7882

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Sep 10, 2021

I originally implemented this with the feature being optional, but the combination of being the default behavior and adding more httpClient calls, I have seen at least one Http Client timeout fail sending to helix; since it's not optional, the productVersion.txt stuff needs to succeed.

#7836

To double check:

…ional, the productVersion.txt stuff needs to succeed.
@MattGal MattGal merged commit 054309c into dotnet:main Sep 10, 2021
MattGal added a commit to MattGal/arcade that referenced this pull request Sep 13, 2021
…ional, the productVersion.txt stuff needs to succeed. (dotnet#7882)
MattGal added a commit that referenced this pull request Sep 13, 2021
…ional, the productVersion.txt stuff needs to succeed. (#7882) (#7889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants