Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also set NUGET enhanced environment variables in MSBuild-Core() #7916

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Sep 20, 2021

https://github.com/dotnet/core-eng/issues/13691 continuation; the problem can happen during toolset restore, where we don't have the variables set. Also turns on logging that the set occurred for future log reading.

To double check:

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@MattGal MattGal merged commit 5df4f90 into dotnet:main Sep 20, 2021
@MattGal
Copy link
Member Author

MattGal commented Sep 20, 2021

I verified that the variables are now in the ToolSetRestore.binlog file.

jakubstilec pushed a commit to jakubstilec/arcade that referenced this pull request Sep 21, 2021
jakubstilec pushed a commit that referenced this pull request Sep 22, 2021
…etting so we can also do it in MSBuild-Core() (#7916) (#7921)

Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants