Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update symboluploader to work around tracing NullRefs #7964

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Update symboluploader to work around tracing NullRefs #7964

merged 2 commits into from
Sep 27, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Sep 26, 2021

Fixes #7924

This works around some issues in flow of activity IDs in the logging that cause a nullref in a symbol publishing operation. Ignore logging the ID when it is null.

@hoyosjs hoyosjs self-assigned this Sep 26, 2021
riarenas
riarenas approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we attempt to re-enable the symuploader subscription so that these come automatically via Maestro?

@mikem8361 mikem8361 mentioned this pull request Sep 27, 2021
Closed
2 tasks
epananth
epananth approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@epananth epananth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.. :/

@hoyosjs hoyosjs enabled auto-merge (squash) September 27, 2021 18:12
@hoyosjs hoyosjs merged commit 30d5be4 into dotnet:main Sep 27, 2021
@hoyosjs hoyosjs deleted the juhoyosa/update-symuploader branch September 28, 2021 04:05
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

@mikem8361 mikem8361 mikem8361 approved these changes

@riarenas riarenas riarenas approved these changes

@epananth epananth epananth approved these changes

Assignees

@hoyosjs hoyosjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException from PublishArtifactsInManifest in ASP.NET Core build
5 participants
@hoyosjs @MattGal @mikem8361 @riarenas @epananth