Enable requesting retry/reboot on Windows XHarness workloads #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatalas
reviewed
Oct 1, 2021
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.apple.sh
Outdated
Show resolved
Hide resolved
lpatalas
reviewed
Oct 1, 2021
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.header.ps1
Outdated
Show resolved
Hide resolved
lpatalas
reviewed
Oct 1, 2021
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.header.ps1
Show resolved
Hide resolved
lpatalas
approved these changes
Oct 1, 2021
|
One question because I'm not familiar with the rest of the code - if we reboot the machine then are those |
Yes, they are part of the work item directory which is removed at the end of the work item. |
lpatalas
reviewed
Oct 1, 2021
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.ps1
Show resolved
Hide resolved
premun
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same pattern we already have on Apple, this should help the MonoVM team react to infrastructure failures inside of their Xunit tests (dotnet/runtime#59679)
Also added new capability to allow setting a reason message via the
.retry/.rebootfile content