Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception logging while publishing to blob storage #8134

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Improve exception logging while publishing to blob storage #8134

merged 1 commit into from
Nov 5, 2021

Commits on Nov 4, 2021

  1. Improve exception logging while publishing to blob storage 

    There can still be errors while uploading files to blob storage, even after confirming that the file doesn't already exist at the given location. See: https://dev.azure.com/dnceng/internal/_build/results?buildId=1443383&view=logs&j=8667c75e-c9c8-5a72-3326-7d35d151733c&t=648bbdf3-1356-5b63-95ae-560e1b5f90bf. Today, that exception is thrown, but since everything is async, it isn't clear what package was having an issue publishing.

This change adds a try/catch around the call to UploadAsync, and will long the file name and blob path along with the exception message if UploadAsync throws an exception.
    @michellemcdaniel
    michellemcdaniel committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    199507b View commit details
    Browse the repository at this point in the history