Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "ignore nonexistent queue" functionality to release/5.0 #8155

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Nov 8, 2021

To double check:

Description

Context: https://github.com/dotnet/core-eng/issues/14572
Port of #8069 (bbb4187). Allows users who want to to ignore non-existent Helix queues, so we don't have to keep every queue that we've ever had in existence in our yaml files forever.

Customer Impact

This change allows customers to decide whether their build should break (and thus require attention) when sending to and end-of-life-d queue, or just print a warning.

Without this change, any old queue that has been removed (e.g. OSX.1012.Amd64) will cause failure once the changes to do this are merged.

Regression

No

Risk

Low; only two queues we'd remove (osx.1012.amd64, redhat.6.amd64) have been used in the past 30 days, from 3.1 release branches, and these can be left alone until addressed.

Workarounds

User will have to work around this by removing dead queues manually without this setting available in the Arcade SDK.

@MattGal MattGal merged commit 41d9f2b into dotnet:release/5.0 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants