Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xliff tasks being loaded even when not needed #8244

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

bekir-ozturk
Copy link
Contributor

@bekir-ozturk bekir-ozturk commented Dec 6, 2021

Fixes an issue created by #8233

After the change above, Xliff tasks package is now loaded even in the cases where it isn't needed.
This causes issues with some repos (and likely others that aren't listed below):

The dotnet/templating and dotnet/test-templates repos seem to be working fine and are not affected by this bug.

The fix is to correct the usage of flags so that Xliff tasks package will only be loaded when needed.
Tested on local clone of winforms repo. Xliff tasks are no longer referenced unless needed.

To double check:

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but do note that the setting is opt-out (true by default) if that matters.

<UsingToolXliff Condition="'$(UsingToolXliff)' == ''">true</UsingToolXliff>

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2021

Ready to merge? It would be good to get aspnetcore and ef dependency updates unblocked.

@bekir-ozturk
Copy link
Contributor Author

The issue is now fixed and the dependency update was merged into aspnetcore repo.

@jonfortescue jonfortescue deleted the dev/bozturk/fix-xliff-tasks branch December 8, 2021 19:35
@sunandabalu
Copy link
Member

sunandabalu commented Dec 9, 2021

We are seeing the xliff failures in our repo with the latest arcade update PR - https://github.com/dotnet/upgrade-assistant/pull/970/checks?check_run_id=4464498289. Assuming the next arcade update should have the fix? @dotnet/dnceng

@riarenas
Copy link
Member

riarenas commented Dec 9, 2021

Yes. the next update will have this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants