Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-determinism in target feed creation #8320

Merged
1 commit merged into from
Jan 6, 2022
Merged

Fix non-determinism in target feed creation #8320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ private void CreateStablePackagesFeedIfNeeded()

private string GetFeedOverride(string feed)
{
foreach (var prefix in FeedOverrides.Keys)
foreach (var prefix in FeedOverrides.Keys.OrderByDescending(f => f.Length))
mmitche marked this conversation as resolved.
Show resolved Hide resolved
{
if (feed.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
{
Expand All @@ -254,7 +254,7 @@ private string GetFeedOverride(string feed)

private string GetFeedSasUri(string feed)
{
foreach (var prefix in FeedSasUris.Keys)
foreach (var prefix in FeedSasUris.Keys.OrderByDescending(f => f.Length))
{
if (feed.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
{
Expand All @@ -267,7 +267,7 @@ private string GetFeedSasUri(string feed)

private string GetFeedKey(string feed)
{
foreach (var prefix in FeedKeys.Keys)
foreach (var prefix in FeedKeys.Keys.OrderByDescending(f => f.Length))
{
if (feed.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
{
Expand Down