Delete unnecessary task in TFM.Sdk #8366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/runtime doesn't build against netcoreappX.X-* tfms anymore, hence the pattern can be deleted.
ericstj
reviewed
Jan 20, 2022
...d.Tasks.TargetFramework.Sdk/src/build/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.props
Show resolved
Hide resolved
ericstj
approved these changes
Jan 20, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task logic can be expressed with msbuild batching instead.
Also removing "netcoreapp" from the regex pattern which trims out unsupported tfm suffixes as dotnet/runtime's projects don't target
netcoreappX.X-*anymore. In addition to that, I'm also removing a capture group which isn't necessary anymore so that the overall regex evaluation is faster as less input needs to be captured.