Adding public API test coverage for Aspire.MongoDB.Driver #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alirexaa
requested review from
radical,
eerhardt and
sebastienros
as code owners
dotnet-issue-labeler
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
community-contribution
56 tasks
…aspire-mongodb-driver
Zombach
reviewed
Aug 7, 2024
tests/Aspire.MongoDB.Driver.Tests/MongoDBDriverPublicApiTests.cs
Outdated
Show resolved
Hide resolved
| public void AddMongoDBClientShouldThrowWhenNameIsNull() | ||
| { | ||
| var builder = Host.CreateEmptyApplicationBuilder(null); | ||
|
|
| public void AddMongoDBClientShouldThrowWhenNameIsEmpty() | ||
| { | ||
| var builder = Host.CreateEmptyApplicationBuilder(null); | ||
|
|
| public void AddKeyedMongoDBClientShouldThrowWhenBuilderIsNull() | ||
| { | ||
| IHostApplicationBuilder builder = null!; | ||
|
|
| public void AddKeyedMongoDBClientShouldThrowWhenNameIsNull() | ||
| { | ||
| var builder = Host.CreateEmptyApplicationBuilder(null); | ||
|
|
| public void AddKeyedMongoDBClientShouldThrowWhenNameIsEmpty() | ||
| { | ||
| var builder = Host.CreateEmptyApplicationBuilder(null); | ||
|
|
sebastienros
approved these changes
Aug 9, 2024
Alirexaa
deleted the
validate-arguments-of-public-methods#aspire-mongodb-driver
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5047 and #2649
Microsoft Reviewers: Open in CodeFlow