Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Addressing review feedback for Aspire.Playground.Tests #5243

Merged
merged 1 commit into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playground/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- Import only when in-repo. For the out-of-repo case a parent Directory.Build.targets does the import -->
<Import Project="$(TestsSharedRepoTestingDir)Aspire.RepoTesting.targets" Condition="'$(RepoRoot)' != ''" />

<PropertyGroup Condition="'$(TestsRunningOutsideOfRepo)' == 'true' or '$(SkipDashboardProjectReference)' == 'true'">
<PropertyGroup Condition="'$(SkipDashboardProjectReference)' == 'true'">
<DefineConstants>SKIP_DASHBOARD_REFERENCE;$(DefineConstants)</DefineConstants>
</PropertyGroup>
</Project>
5 changes: 2 additions & 3 deletions tests/Aspire.Playground.Tests/AppHostTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.Net;
using System.Text.Json;
using Aspire.Hosting.ApplicationModel;
using Aspire.Workload.Tests;
using Microsoft.Extensions.DependencyInjection;
using SamplesIntegrationTests;
using SamplesIntegrationTests.Infrastructure;
Expand All @@ -15,12 +14,12 @@ namespace Aspire.Playground.Tests;

public class AppHostTests
{
private readonly TestOutputWrapper _testOutput;
private readonly ITestOutputHelper _testOutput;
private static readonly string? s_appHostNameFilter = Environment.GetEnvironmentVariable("TEST_PLAYGROUND_APPHOST_FILTER");

public AppHostTests(ITestOutputHelper testOutput)
{
this._testOutput = new TestOutputWrapper(testOutput);
_testOutput = testOutput;
}

[Theory]
Expand Down
4 changes: 2 additions & 2 deletions tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
</PropertyGroup>

<ItemGroup>
<!-- on helix, the file will be in the source directory, so it will get
picked up by msbuild by default -->
<Compile Condition="'$(RepoRoot)' != ''" Include="$(RepoRoot)src\Aspire.Hosting\Utils\PasswordGenerator.cs" />
<Compile Include="$(TestsSharedDir)WorkloadTesting\TestOutputWrapper.cs" />
<Compile Include="$(TestsSharedDir)WorkloadTesting\EnvironmentVariables.cs" />
<Compile Include="$(TestsSharedDir)Logging\*.cs" />

<AspireProjectOrPackageReference Include="Aspire.Hosting" />
Expand Down
Loading