-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/arcade #5682
base: main
Are you sure you want to change the base?
[main] Update dependencies from dotnet/arcade #5682
Conversation
…909.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6
Fix `Multiple top-level headings in the same document [Context: "# Development notes"]`. PR opened upstream - dotnet/arcade#15082 .
…913.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24459.6 -> To Version 9.0.0-beta.24463.2
@radical - it looks like the template tests are failing in both the windows and linux legs. |
…916.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2
// Avoid using the msbuild terminal logger, so the output can be read | ||
// in the tests | ||
EnvVars["VsTestUseMSBuildOutput"] = "false"; | ||
EnvVars["MSBUILDENSURESTDOUTFORTASKPROCESSES"] = "1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baronfel @rainersigwald - should this just happen automatically in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet test should be doing this for you if you use an invocation of it that requires this flag: https://github.com/dotnet/sdk/blob/176e8ca72f5b9111649c49ca43a71d1dd9904bd0/src/Cli/dotnet/commands/dotnet-test/Program.cs#L61
In general MSBuild should not allow worker nodes to stomp all over the central nodes' stdout, VSTest is doing a bad here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I'm adding this here is to avoid the terminal logger. The first one didn't seem to be enough. Do I need to explicitly set _MSBUILDTLENABLED=0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nohwnd can you advise here?
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Microsoft Reviewers: Open in CodeFlow