Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #5682

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 11, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 99b8b1c1-ded8-4084-554e-08dbbf92ebfa
  • Build: 20240916.2
  • Date Produced: September 16, 2024 6:20:31 PM UTC
  • Commit: 04b9022eba9c184a8036328af513c22e6949e8b6
  • Branch: refs/heads/release/9.0
Microsoft Reviewers: Open in CodeFlow

…909.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Sep 11, 2024
Fix `Multiple top-level headings in the same document [Context: "# Development notes"]`. PR opened upstream - dotnet/arcade#15082 .
dotnet-maestro bot and others added 2 commits September 16, 2024 13:05
…913.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24459.6 -> To Version 9.0.0-beta.24463.2
@eerhardt
Copy link
Member

@radical - it looks like the template tests are failing in both the windows and linux legs.

dotnet-maestro bot and others added 2 commits September 17, 2024 17:41
…916.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2
Comment on lines +130 to +133
// Avoid using the msbuild terminal logger, so the output can be read
// in the tests
EnvVars["VsTestUseMSBuildOutput"] = "false";
EnvVars["MSBUILDENSURESTDOUTFORTASKPROCESSES"] = "1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baronfel @rainersigwald - should this just happen automatically in CI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet test should be doing this for you if you use an invocation of it that requires this flag: https://github.com/dotnet/sdk/blob/176e8ca72f5b9111649c49ca43a71d1dd9904bd0/src/Cli/dotnet/commands/dotnet-test/Program.cs#L61

In general MSBuild should not allow worker nodes to stomp all over the central nodes' stdout, VSTest is doing a bad here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I'm adding this here is to avoid the terminal logger. The first one didn't seem to be enough. Do I need to explicitly set _MSBUILDTLENABLED=0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nohwnd can you advise here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants