-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Update dependencies from aspnet/EntityFrameworkCore #17947
[master] Update dependencies from aspnet/EntityFrameworkCore #17947
Conversation
…build 20191218.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19618.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19618.1 - dotnet-ef - 5.0.0-alpha.1.19618.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19618.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19618.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19618.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19618.1 Dependency coherency updates - Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.19562.8 (parent: Microsoft.Extensions.Logging)
@aspnet/build - should this be closed? Seems redundant with #17641 |
Blocked due to 3.1 dependency issues in EF. We need to wait for runtime dependencies to start flowing again. |
…build 20191218.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19618.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19618.2 - dotnet-ef - 5.0.0-alpha.1.19618.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19618.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19618.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19618.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19618.2
…build 20191218.3 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19618.3 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19618.3 - dotnet-ef - 5.0.0-alpha.1.19618.3 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19618.3 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19618.3 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19618.3 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19618.3
Updated to include workarounds from #17641 |
…build 20191219.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19619.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19619.1 - dotnet-ef - 5.0.0-alpha.1.19619.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19619.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19619.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19619.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19619.1
…build 20191222.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19622.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19622.1 - dotnet-ef - 5.0.0-alpha.1.19622.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19622.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19622.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19622.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19622.1
…build 20191223.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19623.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19623.1 - dotnet-ef - 5.0.0-alpha.1.19623.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19623.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19623.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19623.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19623.1
…build 20191223.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19623.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19623.2 - dotnet-ef - 5.0.0-alpha.1.19623.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19623.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19623.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19623.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19623.2
…build 20191223.4 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19623.4 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19623.4 - dotnet-ef - 5.0.0-alpha.1.19623.4 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19623.4 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19623.4 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19623.4 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19623.4
…build 20191223.3 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19623.3 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19623.3 - dotnet-ef - 5.0.0-alpha.1.19623.3 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19623.3 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19623.3 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19623.3 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19623.3
…build 20191224.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19624.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19624.1 - dotnet-ef - 5.0.0-alpha.1.19624.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19624.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19624.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19624.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19624.1
…build 20191224.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19624.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19624.2 - dotnet-ef - 5.0.0-alpha.1.19624.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19624.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19624.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19624.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19624.2
…build 20191226.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19626.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19626.1 - dotnet-ef - 5.0.0-alpha.1.19626.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19626.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19626.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19626.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19626.1
…build 20191226.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19626.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19626.2 - dotnet-ef - 5.0.0-alpha.1.19626.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19626.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19626.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19626.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19626.2
…build 20191226.3 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19626.3 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19626.3 - dotnet-ef - 5.0.0-alpha.1.19626.3 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19626.3 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19626.3 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19626.3 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19626.3
…build 20191227.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.19627.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.19627.1 - dotnet-ef - 5.0.0-alpha.1.19627.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.19627.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.19627.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.19627.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.19627.1
Blocked on dotnet/runtime#1129 flowing to EF and then EF updates coming to this PR. |
…build 20200102.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20052.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20052.1 - dotnet-ef - 5.0.0-alpha.1.20052.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20052.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20052.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20052.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20052.1
…build 20200103.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.1 - dotnet-ef - 5.0.0-alpha.1.20053.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.1
…build 20200103.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.2 - dotnet-ef - 5.0.0-alpha.1.20053.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.2
…build 20200103.3 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.3 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.3 - dotnet-ef - 5.0.0-alpha.1.20053.3 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.3 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.3 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.3 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.3
…build 20200103.4 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.4 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.4 - dotnet-ef - 5.0.0-alpha.1.20053.4 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.4 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.4 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.4 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.4
…build 20200103.5 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.5 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.5 - dotnet-ef - 5.0.0-alpha.1.20053.5 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.5 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.5 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.5 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.5
…build 20200103.6 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20053.6 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20053.6 - dotnet-ef - 5.0.0-alpha.1.20053.6 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20053.6 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20053.6 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20053.6 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20053.6
…build 20200105.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20055.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20055.1 - dotnet-ef - 5.0.0-alpha.1.20055.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20055.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20055.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20055.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20055.1
…build 20200105.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20055.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20055.2 - dotnet-ef - 5.0.0-alpha.1.20055.2 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20055.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20055.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20055.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20055.2
…build 20200106.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-alpha.1.20056.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-alpha.1.20056.1 - dotnet-ef - 5.0.0-alpha.1.20056.1 - Microsoft.EntityFrameworkCore - 5.0.0-alpha.1.20056.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-alpha.1.20056.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-alpha.1.20056.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-alpha.1.20056.1
In addition to dotnet/runtime#1129, this is seemingly blocked by a failure within the EF migration tool:
@ajcvickers was a new dependency on 3.1 added to the migrations tool? |
@ryanbrandenburg Not that I am aware of. @bricelam Any ideas? |
Looking at this some more, why are EF dependencies being upped to 5.0? EF Core for the time being is a set of .NET Standard 2.1 libraries together with tooling built against .NET Core 3.1. We want to keep it this way, at least until closer to the 5.0 release when we will revisit what we target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is reverting some of the changes we made to pin 3.1.
Sorry, got confused. :-) However, EF Core 5.0 for now should continue to depend on .NET Standard 2.1, released 3.1 packages, and tooling that needs .NET Core 3.1. Nothing should require 5.0.
@ryanbrandenburg that's the known issue which @Tratcher commented on in #17947 (comment) Basically the
Dependencies from EF aren't being changed here. However those from Extensions must align with the rest of AspNetCore i.e. target @ajcvickers @bricelam my preference here would be a near-term fix in EF Core allowing the tools to roll forward on major version i.e. from 3.1 to 5.0. If that happened, this repo and any customers targeting |
Another option might be to change https://github.com/aspnet/EntityFrameworkCore/blob/master/src/dotnet-ef/dotnet-ef.csproj#L15 to use |
Any reason we don't want the tool to roll forward anyway, long term? |
cc @halter73 |
I just started my buildops rotation. Is this still blocked? |
Yes. Need the dotnet/runtime changes to flow into this repo before this PR is likely to build correctly. @wtgodbe please correct me if I'm wrong. |
I think we can close this one in favor of #18247 |
This pull request updates the following dependencies
From https://github.com/aspnet/EntityFrameworkCore
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format