Use Microsoft.AspNetCore.Razor.Language for all CPDs #18669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
JunTaoLuo
approved these changes
Jan 29, 2020
dougbu
requested changes
Jan 29, 2020
There was a problem hiding this comment.
These changes look bizarre. Why is the CPD hierarchy going to be so messy?
I could understand changing CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64" to CoherentParentDependency="Microsoft.Extensions.Logging" i.e. use the logging package for all dotnet/runtime dependencies. But, do not take dotnet/extensions out of the hierarchy until that repo is consolidated.
I also suggest changing CPD in dotnet/extensions and dotnet/aspnetcore-tooling before doing anything in this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Microsoft.AspNetCore.Razor.Languagefor all CoherentParentDependencies, except for the dependency on Roslyn (which isn't depended on by AspNetCore-Tooling). This will allow us to avoid DARC choosing EFCore as the parent for any CPDs, which would cause us to downgrade to 3.1 versions of corefx (now runtime) dependencies.@mmitche @dougbu @JunTaoLuo PTAL