Cleaning up AzDO Test Run Names #19575

analogrelay · 2020-03-04T18:19:32Z

I was spelunking around AzDO APIs and found that the test run names were a bit messy. Trying something to clean them up a little bit and see what we find.

analogrelay · 2020-03-04T19:38:38Z

Better, but not perfect:

analogrelay · 2020-03-05T18:33:21Z

Going to look in to what I can do about the remaining run names. It's possible they come from Arcade though.

analogrelay · 2020-03-05T19:19:39Z

eng/common/templates/job/job.yml

        searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)'
+        testRunTitle: $(AgentOsName)-$(BuildConfiguration)-xunit
+        mergeTestResults: true


I know this is in eng/common which is not to be touched. I won't merge this, just testing something and will contribute to Arcade if it yields a good result.

analogrelay · 2020-03-06T00:04:06Z

This looks much better. I'll need to make some Arcade changes to actually make it happen though.

davidfowl · 2020-03-29T03:10:45Z

YESSSSSSSS please.

analogrelay · 2020-03-30T18:23:10Z

YESSSSSSSS please.

Needs a change to dotnet/arcade (the changes in eng/common in this PR).

MattGal

Seems reasonable and like a nice cleanup. I'd like to learn more about the lifespan and stateful-ness of the dump collector thing. if possible.

MattGal · 2020-03-30T20:45:39Z

.azure/pipelines/jobs/default-build.yml

+            name: NetCorePublic-Pool
+            ${{ if ne(parameters.isTestingJob, true) }}:
+              # Visual Studio Build Tools
+              queue: BuildPool.Server.Amd64.VS2019.BT.Open


Suggestion: Unrelated to this PR, but please consider just using Enterprise for either build; since this was primarily in place to be a non-expiring SKU from before RTW, it'd be nice to eventually obsolete buildtools skus since we won't be able to ever obsolete enterprise and it should be able to build buildtools.

This is only showing as edited because of the indentation change. I'd suggest filing a new issue to discuss that.

MattGal · 2020-03-30T20:47:23Z

.azure/pipelines/jobs/default-build.yml

+        - ? ${{ if and(eq(parameters.agentOs, 'Windows'), eq(parameters.isTestingJob, true)) }}
+          : - powershell: ./eng/scripts/InstallProcDump.ps1
+              displayName: Install ProcDump
+            - powershell: ./eng/scripts/StartDumpCollectionForHangingBuilds.ps1 $(ProcDumpPath)procdump.exe artifacts/dumps/ (Get-Date).AddMinutes(160) dotnet


would like to learn more about this, such as what happens when the build ends (does it leave stuff running?) does it change machine state in any way that survives a reboot? does it install anything? , etc.

cc @javiercn

Also only showing in this PR because of the indentation change. Probably something we should have a separate discussion about.

dougbu

Curious…

dougbu · 2020-04-01T18:20:28Z

.azure/pipelines/jobs/default-build.yml

-  agentOs: 'Windows'
-  buildArgs: ''
-  configuration: 'Release'
+  agentOs: "Windows"


Why switch to double-quotes? YAML supports either

🤷‍♀ I'm fine either way. Wasn't intentional.

Prefer we left these alone to avoid unnecessary churn

dougbu · 2020-04-01T18:36:05Z

.azure/pipelines/jobs/default-build.yml

+      timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
+      cancelTimeoutInMinutes: ${{ parameters.cancelTimeoutInMinutes }}
+      ? ${{ if and(eq(variables['System.TeamProject'], 'internal'), eq(parameters.agentOs, 'Windows'), eq(parameters.codeSign, 'true')) }}
+      : enableMicrobuild: true


Where is this syntax defined? It's not mentioned in https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops and the YAML 1.2 key / value syntax seems odd here.

Wasn't changed in this PR, so 🤷‍♀

This was changed in this PR. See https://github.com/dotnet/aspnetcore/pull/19575/files#diff-f3d39efe7528a28e4995c18938c8a3d3L78

Seems like something is doing lots of extra changes to the YAML files you're touching, making it hard to see what's really changing.

davidfowl · 2020-04-01T19:50:12Z

Can we get this merged? What’s left?

analogrelay · 2020-04-01T20:34:56Z

Can we get this merged? What’s left?

We need to take the new arcade change in and someone needs to rebase and undo modifications to eng/common

BrennanConroy · 2020-04-01T20:35:50Z

I'd like us to fix up the js test names too

analogrelay · 2020-04-01T20:37:34Z

We can do that in a separate PR. This change should fix the top-level Test Run names, but if you want to fix the individual test names, we'll have to do that in the JS tests themselves.

davidfowl · 2020-04-01T21:11:06Z

Lets get it merged then. This one right dotnet/arcade#5171?

analogrelay · 2020-06-23T16:24:27Z

Is this still relevant @davidfowl @Pilchie ?

Pilchie · 2020-06-23T21:53:14Z

I think this is still relevant. Going to close/reopen to get another run.

analogrelay · 2020-06-24T03:56:31Z

With the Arcade PR now merged, it should be ready to go. I just don't have access to AzDO to see if it's working 😆

BrennanConroy · 2020-06-24T04:01:37Z

Ah, merge conflicts

jkotalik · 2020-11-05T19:21:32Z

@Pilchie should we delegate finishing this PR to someone else? @BrennanConroy do you have more context?

jkotalik · 2020-11-05T19:21:45Z

Is this just renaming queues to more clear names?

BrennanConroy · 2020-11-05T19:24:57Z

Is this just renaming queues to more clear names?

Basically, see the screenshots above.

Pilchie · 2020-11-05T19:35:27Z

That would be great. My yaml isn't great, and these files have changed enough that I had a hard time working through the conflicts here. Any volunteers @BrennanConroy / @dotnet/aspnet-build / @dotnet/aspdoi ?

BrennanConroy · 2020-11-05T19:36:56Z

Sure, I've complained about these names before and have done minor attempts at fixing them in the past. I'll clean this up

BrennanConroy · 2020-11-06T03:11:40Z

Thanks Andrew, closing in favor of #27560 (which is mostly just a copy of this PR)

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2020

analogrelay changed the title ~~trying something to clean up the test run identifiers~~ Cleaning up AzDO Test Run Names Mar 4, 2020

analogrelay added 3 commits March 5, 2020 11:03

trying something to clean up the test run identifiers

bc7cf2a

fix dat yaml

3de8ecb

I know eng/common is sacred, just trying something out

136deb4

analogrelay force-pushed the anurse/clean-up-test-run-data branch from 980ed6a to 136deb4 Compare March 5, 2020 19:19

analogrelay commented Mar 5, 2020

View reviewed changes

more yaml futzing

9c40fef

markwilkie requested review from ChadNedzlek, tmat, MattGal, alexperovich and Chrisboh March 30, 2020 20:29

MattGal reviewed Mar 30, 2020

View reviewed changes

dougbu reviewed Apr 1, 2020

View reviewed changes

Pilchie closed this Jun 23, 2020

Pilchie reopened this Jun 23, 2020

BrennanConroy marked this pull request as ready for review June 24, 2020 04:01

mkArtakMSFT assigned Pilchie Jun 29, 2020

BrennanConroy assigned BrennanConroy and unassigned Pilchie Nov 5, 2020

BrennanConroy mentioned this pull request Nov 5, 2020

Cleaning up AzDO Test Run Names #27560

Merged

BrennanConroy closed this Nov 6, 2020

BrennanConroy deleted the anurse/clean-up-test-run-data branch November 6, 2020 03:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleaning up AzDO Test Run Names #19575

Cleaning up AzDO Test Run Names #19575

analogrelay commented Mar 4, 2020

analogrelay commented Mar 4, 2020

analogrelay commented Mar 5, 2020

analogrelay Mar 5, 2020

analogrelay commented Mar 6, 2020

davidfowl commented Mar 29, 2020

analogrelay commented Mar 30, 2020

MattGal left a comment

MattGal Mar 30, 2020

analogrelay Mar 30, 2020

MattGal Mar 30, 2020

davidfowl Mar 30, 2020

analogrelay Mar 30, 2020

dougbu left a comment

dougbu Apr 1, 2020

analogrelay Apr 1, 2020

dougbu Apr 1, 2020

dougbu Apr 1, 2020

analogrelay Apr 1, 2020

dougbu Apr 1, 2020

davidfowl commented Apr 1, 2020

analogrelay commented Apr 1, 2020

BrennanConroy commented Apr 1, 2020

analogrelay commented Apr 1, 2020 •

edited

Loading

davidfowl commented Apr 1, 2020

analogrelay commented Jun 23, 2020

Pilchie commented Jun 23, 2020

analogrelay commented Jun 24, 2020

BrennanConroy commented Jun 24, 2020

jkotalik commented Nov 5, 2020

jkotalik commented Nov 5, 2020

BrennanConroy commented Nov 5, 2020

Pilchie commented Nov 5, 2020

BrennanConroy commented Nov 5, 2020

BrennanConroy commented Nov 6, 2020

Cleaning up AzDO Test Run Names #19575

Cleaning up AzDO Test Run Names #19575

Conversation

analogrelay commented Mar 4, 2020

analogrelay commented Mar 4, 2020

analogrelay commented Mar 5, 2020

Choose a reason for hiding this comment

analogrelay commented Mar 6, 2020

davidfowl commented Mar 29, 2020

analogrelay commented Mar 30, 2020

MattGal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dougbu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidfowl commented Apr 1, 2020

analogrelay commented Apr 1, 2020

BrennanConroy commented Apr 1, 2020

analogrelay commented Apr 1, 2020 • edited Loading

davidfowl commented Apr 1, 2020

analogrelay commented Jun 23, 2020

Pilchie commented Jun 23, 2020

analogrelay commented Jun 24, 2020

BrennanConroy commented Jun 24, 2020

jkotalik commented Nov 5, 2020

jkotalik commented Nov 5, 2020

BrennanConroy commented Nov 5, 2020

Pilchie commented Nov 5, 2020

BrennanConroy commented Nov 5, 2020

BrennanConroy commented Nov 6, 2020

analogrelay commented Apr 1, 2020 •

edited

Loading