Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source-build workaround for sourcelink submodule issue #39324

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

MichaelSimons
Copy link
Member

This change removes source-build workaround for a sourcelink submodule issue that has now been addressed. This change is currently being carried in a source-build patch that needs to be removed.

Fixes dotnet/source-build#2354

@MichaelSimons MichaelSimons requested a review from a team as a code owner January 5, 2022 17:31
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 5, 2022
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a fan of removing special cases 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ArPow] Remove aspnetcore patches
3 participants