Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Stop signing apphost.exe and comhost.dll in nupkg (#7547)
Browse files Browse the repository at this point in the history
* Stop signing apphost.exe and comhost.dll in nupkg
  • Loading branch information
dagood committed Aug 2, 2019
1 parent 9b9814c commit 0245522
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
<!-- Find bundle artifacts, which need multiple stages to fully sign. -->
<BundleInstallerEngineArtifact Include="$(ArtifactsPackagesDir)**/*engine.exe" />
<BundleInstallerExeArtifact Include="$(ArtifactsPackagesDir)**/*.exe" />
</ItemGroup>

<!-- apphost and comhost template files are not signed, by design. -->
<FileSignInfo Include="apphost.exe;comhost.dll" CertificateName="None" />
</ItemGroup>>

<ItemGroup Condition="'$(SignBinaries)' == 'true'">
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/hostfxr.dll" />
Expand All @@ -27,7 +30,6 @@
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/ijwhost.dll" />
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/winrthost.dll" />
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/nethost.dll" />
<!-- Note: apphost is not signed, by design. -->

<ItemsToSign Include="$(CrossGenRootPath)**/*.dll" />

Expand Down

0 comments on commit 0245522

Please sign in to comment.