This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Jit: fix issue with single-def type propagation #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid overly aggressive type propagation when there are multiple reaching definitions, only propagate types to single-IL-def locals when the definiting value comes from the same basic block as the store. We check this conservatively by insisting that the block's entry stack be empty. Added a test case where the jit will improperly devirtualize without such a check. Closes #10858.
|
Should also fix various x86 desktop assertion failures; still verifying this. 7 diffs in the framework jit-diff set. They are all cases where we're now overly conservative, eg the stack is non-empty going into the block but the value that reaches the single-IL-def comes from within the block. |
|
Desktop tests also look good. |
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overly aggressive type propagation when there are multiple
reaching definitions, only propagate types to single-IL-def locals
when the defining value comes from the same basic block as the store.
We check this conservatively by insisting that the block's entry stack
be empty.
Added a test case where the jit will improperly devirtualize without
such a check.
Closes #10858.