This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Make ConnectHelper.ConnectAsync return ValueTask<Stream> #24244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor optimization via playing a bit better perf-wise with changes being made in coreclr.
|
Seems fine to me, but why does this matter? |
Because then it hits https://github.com/dotnet/coreclr/pull/14178/files#diff-bc8ce62cfb625ddcc19d1f21b5c8b5c1R437 |
|
Makes sense, thanks. Sorry, I looked at the discussion for 14178 but should have just looked at the code. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…fx#24244) Minor optimization via playing a bit better perf-wise with changes being made in coreclr. Commit migrated from dotnet/corefx@c45e6b3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor optimization via playing a bit better perf-wise with changes being made in coreclr in dotnet/coreclr#14178.
cc: @geoffkizer