Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Port some methods of the VB Interaction module #39574

Merged
merged 7 commits into from
Jul 20, 2019
Merged

Port some methods of the VB Interaction module #39574

merged 7 commits into from
Jul 20, 2019

Conversation

ehasis
Copy link
Contributor

@ehasis ehasis commented Jul 17, 2019 •
edited
Loading

  • Ported Choose, Partition and Switch methods
  • Minor changes in the Partition implementation to use StringBuilder as there was comments suggesting this
  • The tests is based on some code available from @danmosemsft repo
  • Relates with #31181

@stephentoub stephentoub requested a review from cston July 17, 2019 20:14
@stephentoub stephentoub reopened this Jul 18, 2019
@danmoseley
Copy link
Member

@KathleenDollard the highest usage for any of these is 0.3%. So to my mind this does not meet the bar to port to 3.0 and must wait for 5.0 (as we cannot add API in 3.1). If you believe it should be in 3.0 please let's discuss in tactics meeting.

cston
cston approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ehasis!

@danmoseley
Copy link
Member

@cston ready to merge? Sounds like we want a PR against 3.0 also.

@cston cston merged commit 4585133 into dotnet:master Jul 20, 2019
@cston
Copy link
Member

cston commented Jul 20, 2019

@ehasis, thanks for the contribution!

@ehasis ehasis deleted the vb-interaction branch July 20, 2019 14:58
@karelz karelz added this to the 5.0 milestone Aug 3, 2019
@benaadams benaadams mentioned this pull request Feb 1, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@ehasis @cston
Port some methods of the VB Interaction module (dotnet/corefx#39574)
d6895b2 


Commit migrated from dotnet/corefx@4585133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@cston cston cston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehasis @danmoseley @cston @stephentoub @karelz