Introducing netstandard13aot target group in System.IO #6597

tarekgh · 2016-03-02T21:28:36Z

We need to build System.IO that work with corert which we need to get rid of WinRT
dependencies and that will require to have different code in System.IO which require
creating a new target group. This change should be no-op for other target groups.

tarekgh · 2016-03-02T21:29:15Z

@weshaggard @ericstj could you please have a look?

weshaggard · 2016-03-03T06:25:26Z

src/System.IO/src/netstandard15aot/project.json

@@ -0,0 +1,19 @@
+{
+  "frameworks": {
+    "netstandard1.5": {


I thought you were going to make this netstandard13aot.

Since this has been changed to netstandard13aot, is the commit message still valid?
The PR title and commit message: "Introducing netstandard51aot target.."

Don't do that. Appending aot to the framework moniker is not valid. 'netstandard13aot' is just an arbitrary string the build tooling is using to enable cross-compilation.

Agreed. The project.json should just be netstandard1.3 for the framework. netstandard13aot is just shorthand for our build system.

ericstj · 2016-03-03T20:01:10Z

dir.props

@@ -308,6 +309,13 @@
        <NuGetTargetMoniker>.NETCore,Version=v5.0</NuGetTargetMoniker>
      </PropertyGroup>
    </When>
+    <When Condition="'$(TargetGroup)'=='netstandard13aot'">
+      <PropertyGroup>
+        <PackageTargetFramework>netstandard13aot</PackageTargetFramework>


should be just nestandard1.3

tarekgh · 2016-03-04T16:57:44Z

@weshaggard & @ericstj I have fixed the code according to your comment and also included the packaging change as Eric described to me.

ericstj · 2016-03-04T17:04:57Z

src/System.IO/src/System.IO.csproj

    <SkipCommonResourcesIncludes>true</SkipCommonResourcesIncludes>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
    <ExcludeAssemblyInfoPartialFile>true</ExcludeAssemblyInfoPartialFile>
    <StringResourcesPath>Resources/Strings.netcore50aot.resx</StringResourcesPath>
+    <SkipValidatePackageTargetFramework Condition="'$(TargetGroup)' == 'netstandard13aot'">true</SkipValidatePackageTargetFramework>


Why was this required?

If you just needed to exclude the System.Private references you can use @(ValidateIgnoreReference) to do so.

tarekgh · 2016-03-04T17:31:32Z

@ericstj fixed the code according to your comments.

ghost · 2016-03-04T18:02:55Z

You may as well want to run git commit --amned and update the commit message to netstandard13aot.

tarekgh · 2016-03-04T18:37:29Z

@jasonwilliams200OK I have updated the commit message. thanks

tarekgh · 2016-03-04T19:20:15Z

@dotnet-bot could you please test this?

ericstj · 2016-03-04T20:06:55Z

Builds are failing because you missed the update to system.io.builds.

weshaggard · 2016-03-04T22:12:51Z

src/System.IO/src/System.IO.csproj

+
+  <ItemGroup Condition="'$(TargetGroup)' == 'netstandard13aot'">
+    <TargetingPackReference Include="System.Private.Interop" />
+    <ValidateIgnoreReference Include="System.Private.Interop" />


This can be generalized to <ValidateIgnoreReference Inlcude="@(TargetingPackReference)" /> I know it is only one in this case but it might be better to generalize this. If we start getting more of these libraries we should actually add this in a common target in BuildTools.

I updated that. it is a good idea anyway

ericstj · 2016-03-04T22:16:42Z

LGTM, OK to merge once all builds pass.

tarekgh · 2016-03-04T22:21:20Z

thanks @ericstj for your help and review here

We need to build System.IO that work with corert which we need to get rid of WinRT dependencies and that will require to have different code in System.IO which require creating a new target group. This change should be no-op for other target groups. Conflicts: src/System.IO/src/System.IO.csproj

Introducing netstandard13aot target group in System.IO

Introducing netstandard13aot target group in System.IO Commit migrated from dotnet/corefx@36f0fab

dnfclas added the cla-already-signed label Mar 2, 2016

dotnet-bot added the 2 - In Progress label Mar 2, 2016

tarekgh force-pushed the netstandard15aot branch from 5ff8d09 to fff4f2c Compare March 2, 2016 21:49

weshaggard reviewed Mar 3, 2016
View reviewed changes

tarekgh force-pushed the netstandard15aot branch from fff4f2c to 10974ad Compare March 3, 2016 16:49

tarekgh changed the title ~~Introducing netstandard51aot target group in System.IO~~ Introducing netstandard13aot target group in System.IO Mar 3, 2016

ericstj reviewed Mar 3, 2016
View reviewed changes

tarekgh force-pushed the netstandard15aot branch from 10974ad to 7aeee56 Compare March 4, 2016 16:52

ericstj reviewed Mar 4, 2016
View reviewed changes

tarekgh force-pushed the netstandard15aot branch from 7aeee56 to 36fe3bd Compare March 4, 2016 17:29

tarekgh force-pushed the netstandard15aot branch from 36fe3bd to 99d2365 Compare March 4, 2016 18:35

tarekgh force-pushed the netstandard15aot branch from 99d2365 to f861a33 Compare March 4, 2016 21:47

weshaggard reviewed Mar 4, 2016
View reviewed changes

tarekgh force-pushed the netstandard15aot branch from f861a33 to 25715bf Compare March 4, 2016 22:19

tarekgh force-pushed the netstandard15aot branch from 25715bf to 34154e9 Compare March 5, 2016 00:57

tarekgh added a commit that referenced this pull request Mar 5, 2016

Merge pull request #6597 from tarekgh/netstandard15aot

36f0fab

Introducing netstandard13aot target group in System.IO

tarekgh merged commit 36f0fab into dotnet:master Mar 5, 2016

dotnet-bot removed the 2 - In Progress label Mar 5, 2016

tarekgh deleted the netstandard15aot branch November 16, 2016 17:57

karelz modified the milestone: 1.0.0-rtm Dec 3, 2016

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Merge pull request dotnet/corefx#6597 from tarekgh/netstandard15aot

46c32b4

Introducing netstandard13aot target group in System.IO Commit migrated from dotnet/corefx@36f0fab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing netstandard13aot target group in System.IO #6597

Introducing netstandard13aot target group in System.IO #6597

tarekgh commented Mar 2, 2016

tarekgh commented Mar 2, 2016

weshaggard Mar 3, 2016

ghost Mar 3, 2016

ericstj Mar 3, 2016

weshaggard Mar 3, 2016

ericstj Mar 3, 2016

tarekgh commented Mar 4, 2016

ericstj Mar 4, 2016

ericstj Mar 4, 2016

tarekgh commented Mar 4, 2016

ghost commented Mar 4, 2016

tarekgh commented Mar 4, 2016

tarekgh commented Mar 4, 2016

ericstj commented Mar 4, 2016

weshaggard Mar 4, 2016

tarekgh Mar 4, 2016

ericstj commented Mar 4, 2016

tarekgh commented Mar 4, 2016

Introducing netstandard13aot target group in System.IO #6597

Introducing netstandard13aot target group in System.IO #6597

Conversation

tarekgh commented Mar 2, 2016

tarekgh commented Mar 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarekgh commented Mar 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarekgh commented Mar 4, 2016

ghost commented Mar 4, 2016

tarekgh commented Mar 4, 2016

tarekgh commented Mar 4, 2016

ericstj commented Mar 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericstj commented Mar 4, 2016

tarekgh commented Mar 4, 2016