This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add tests to DateTimeFormatInfo #6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds some tests I felt were missing from the project - Brings coverage up to 75% I also removed some usings that went unremoved in my recent cleanup work
| [Fact] | ||
| public void Calendar_InvariantInfo() | ||
| { | ||
| Assert.Equal(typeof(GregorianCalendar), DateTimeFormatInfo.InvariantInfo.Calendar.GetType()); |
There was a problem hiding this comment.
This would be better as:
Assert.IsType<GregorianCalendar>(DateTimeFormatInfo.InvariantInfo.Calendar);
|
A few nits, otherwise LGTM. |
|
@stephentoub as ever, thanks for the review and comments. |
|
LGTM. Thanks 😄 |
|
Test Innerloop CentOS7.1 Debug Build and Test please |
|
LGTM too. |
stephentoub
added a commit
that referenced
this pull request
Mar 5, 2016
…rmat-info Add tests to DateTimeFormatInfo
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…-date-time-format-info Add tests to DateTimeFormatInfo Commit migrated from dotnet/corefx@fc515b2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed some usings that went unremoved in my recent cleanup work