Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] List of metrics built into .NET #36748

Open
1 of 5 tasks
JamesNK opened this issue Aug 18, 2023 · 5 comments
Open
1 of 5 tasks

[Metrics] List of metrics built into .NET #36748

JamesNK opened this issue Aug 18, 2023 · 5 comments
Assignees
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri3

Comments

@JamesNK
Copy link
Member

JamesNK commented Aug 18, 2023

https://learn.microsoft.com/en-us/dotnet/core/diagnostics/metrics should have a list of metrics built into .NET. This would be like the well-known counters page - https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters.

For each meter name, there should be a table with the counter names, descriptions, .NET added versions. The counter name could link to OTel semantic conventions site. That allows people to see more information about the counter and its attributes.

Open question: Should the list here be just the dotnet/runtime metrics, or should it include ASP.NET Core metrics?


Proposal:

  • There are separate built-in metrics docs pages for runtime and aspnetcore. There are too many instruments and attributes for one page, and we'll only add more in the future.
    • Runtime (containing DNS and HttpClient instruments)
    • ASP.NET Core (HTTP, Kestrel, middleware, signalr, etc).
  • Each page starts with a summary that has a bullet point list of meter names and a description of what kind of counters a meter has. The name links to meter group on the page.
  • Instruments are grouped on the page by meter name. Linked to by the page summary.
  • Instrument name, type, unit, and description are displayed along with attribute name, type, description, example (maybe), and presence. There is a PR in ASP.NET Core that shows this layout - Built in metrics /2 RC 2 hold AspNetCore.Docs#29760 (this proposal eventually replaces the PR)
  • Under each instrument, there is a link to its definition on OTel Semantic Conventions. Our docs will never go into the level of detail of OTel docs, so the goal is to provide enough information on learn.microsoft.com for someone to use a counter successfully and then a link to view the full definition if required.

Items:

@noahfalk
Copy link
Member

Should the list here be just the dotnet/runtime metrics, or should it include ASP.NET Core metrics?

I'd propose to have the list include ASP.NET Core metrics because I imagine that is simpler for users and follows precedent we already set with EventCounters. Does that sound good or do you see a particular benefit in separating them?

@JamesNK
Copy link
Member Author

JamesNK commented Aug 25, 2023

I think having them in the same document (or child doc if all counters are too much for one doc) is fine.

They just need to be grouped under an ASP.NET Core section that we can link to from ASP.NET Core docs.

If it turns out to be a problem in the future then it's simple to change.

@gewarren gewarren added doc-idea Indicates issues that are suggestions for new topics [org][type][category] and removed ⌚ Not Triaged Not triaged labels Aug 29, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Sep 14, 2023

@noahfalk @antonfirsov @joperezr @Rick-Anderson @lmolkova I updated the issue with a proposal for displaying built-in metrics in our docs. Feedback welcome.

I also added a list of tasks to complete.

@noahfalk
Copy link
Member

What you suggested seems fine. I'll probably have a better sense for it once I've got an initial draft after which feedback is welcome. Its still in my todo list, just not at the top quite yet, almost there.

noahfalk added a commit to noahfalk/docs that referenced this issue Sep 22, 2023
noahfalk added a commit to noahfalk/docs that referenced this issue Sep 22, 2023
noahfalk added a commit to noahfalk/docs that referenced this issue Sep 22, 2023
noahfalk added a commit that referenced this issue Oct 16, 2023
* Add a reference for new .NET 8 metrics

Part of the work for #36748

---------

Co-authored-by: Anton Firszov <antonfir@gmail.com>
@noahfalk
Copy link
Member

@Rick-Anderson - now that #37213 is merged and you are taking over on editing, mind if I assign this issue to you? I think the remaining work is mostly editing and cross-referencing once all the content is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri3
Projects
None yet
Development

No branches or pull requests

4 participants