Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json - write raw JSON #25792

Merged
merged 3 commits into from
Aug 25, 2021
Merged

System.Text.Json - write raw JSON #25792

merged 3 commits into from
Aug 25, 2021

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Aug 24, 2021 •
edited
Loading

Fixes #25600

File Type File Name Published Url
Content docs/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter.md https://review.docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter?branch=main

@dotnet-bot dotnet-bot added this to the August 2021 milestone Aug 24, 2021
@tdykstra tdykstra marked this pull request as ready for review August 24, 2021 19:18
@tdykstra tdykstra requested review from BillWagner and a team August 24, 2021 19:18
BillWagner
BillWagner approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra merged commit 70c87af into dotnet:main Aug 25, 2021
@tdykstra tdykstra mentioned this pull request Aug 25, 2021
Merged
@tdykstra tdykstra added the okr-freshness OKR: Freshness of content label Sep 14, 2021
layomia
layomia reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter.md
In some scenarios, you might want to write "raw" JSON to a JSON payload that you're creating with `Utf8JsonWriter`. Here are typical scenarios:

* You have an existing JSON payload that you want to enclose in new JSON.
* You want to format values differently from the default Utf8JsonWriter formatting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utf8JsonWriter -> Utf8JsonWriter

@tdykstra tdykstra mentioned this pull request Sep 22, 2021
Merged
@tdykstra tdykstra deleted the stjrawjsonvalue branch September 22, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layomia layomia layomia left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
August 2021
Development

Successfully merging this pull request may close these issues.

Document ability to “write raw” JSON with System.Text.Json.Utf8JsonWriter
4 participants
@tdykstra @BillWagner @layomia @dotnet-bot