Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining missing docs in System #10373

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add remaining missing docs in System #10373

merged 2 commits into from
Sep 10, 2024

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Sep 6, 2024

Summary

Add remaining missing docs in System mentioned in dotnet/runtime#105987

Fixes dotnet/runtime#105987

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime

This comment was marked as resolved.

Copy link

Learn Build status updates of commit f839563:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Delegate.xml ✅Succeeded View
xml/System/Delegate+InvocationListEnumerator`1.xml ✅Succeeded View
xml/System/MemoryExtensions.xml ✅Succeeded View
xml/System/MemoryExtensions+SpanSplitEnumerator`1.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Comment on lines +88 to +89
<summary>Implements IEnumerable.GetEnumerator() to return 'this' as the IEnumerator.</summary>
<returns>An IEnumerator instance that can be used to iterate through the invocation targets of the delegate.</returns>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also get up the corresponding PR against dotnet/runtime, to ensure that those XML doc comments are up to date?

It should make it simpler to get those to be the eventual source of truth.

xml/System/Type.xml Show resolved Hide resolved
xml/System/Type.xml Show resolved Hide resolved
Copy link

Learn Build status updates of commit 329a1da:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Delegate.xml ✅Succeeded View
xml/System/Delegate+InvocationListEnumerator`1.xml ✅Succeeded View
xml/System/MemoryExtensions.xml ✅Succeeded View
xml/System/MemoryExtensions+SpanSplitEnumerator`1.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@buyaa-n buyaa-n merged commit 259fed3 into dotnet:main Sep 10, 2024
3 checks passed
@buyaa-n buyaa-n deleted the system branch September 10, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port System docs for .NET 9 APIs
3 participants