-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed String to string. IDE0049 #10384
Conversation
Learn Build status updates of commit 5838cae: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
tag @gewarren I know that our general guideline is to use |
Yes, I don't see why not. |
@muhammadzakriashahid Can you add a project file similar to https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/csharp/System/Math/E/Project.csproj but for .net8.0 in the directory that contains the snippet? This is a newer requirement that we enforce whenever a code snippet is modified so we can ensure it compiles. |
5838cae
to
fbe367c
Compare
@dotnet-policy-service agree |
Learn Build status updates of commit fbe367c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
haven't heard from you guys |
Thanks @muhammadzakriashahid |
Learn Build status updates of commit f9f16d7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Summary
Describe your changes here.
i change the String type to string. Because of the rule ID IDE0049 Use language keywords instead of framework type names for type references.
Fixes #Issue_Number (if available)