.NET 9 RC 1 updates #10395
.NET 9 RC 1 updates #10395
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=456908&view=results source_repo.branch:net9-rc1 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=456964&view=results source_repo.branch:net9-rc1 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
merriemcgaw,
JeremyKuhne,
a team,
AaronRobinsonMSFT,
jkoritzinsky,
cston and
333fred
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
xml/System/ObsoleteAttribute.xml
Outdated
| For more information about using attributes, see [Attributes](/dotnet/standard/attributes/). | ||
| ]]></format> | ||
| </remarks> | ||
| Source code imported from |
There was a problem hiding this comment.
@huangmin-ms Can you help me figure out where this is coming from? There are no System.Runtime.xml files in the binaries repo under dotnet.
There was a problem hiding this comment.
@gewarren
It is coming from Microsoft.Extensions.Diagnostics.ResourceMonitoring.xml of netframework.
Although it is an internal sealed class in this dll. It is a public in mscorlib.dll in the same moniker.
Currently Mdoc will not match the dll file name with the xml file name when importing the related docs.
Not sure why an internal sealed class was documenting in the xml, is it expected?
There was a problem hiding this comment.
@carlossanlop Any idea why the Microsoft.Extensions.Diagnostics.ResourceMonitoring.dll XML doc file would have documentation for System.ObsoleteAttribute?
There was a problem hiding this comment.
@huangmin-ms If there is more than one XML doc file for an API, how does mdoc choose which one to use (since docs are shared for all versions/monikers)?
There was a problem hiding this comment.
@dotnet/area-system-diagnostics @tarekgh do you folks know where ResourceMonitoring lives? I cannot find it. I wanted to see if it is somehow publishing System.ObsoleteAttribute in its ref.
There was a problem hiding this comment.
@carlossanlop It's coming from .NET Framework code.
Sounds more like a question for @HeathAr or someone in her team.
There was a problem hiding this comment.
@huangmin-ms If there is more than one XML doc file for an API, how does mdoc choose which one to use (since docs are shared for all versions/monikers)?
Firstly, sort alphabetically by moniker name. then sort alphabetically by the the name of the xml.
For example: if one API exits in doc1.xml and doc2.xml of net-9.0 and doc1.xml and doc2.xml of netframework-4.8.1.
It will use doc2.xml in netframework-4.8.1.
There was a problem hiding this comment.
@carlossanlop I was mistaken. This is coming from the dotnet/extensions repo. They inject ObsoleteAttribute for down-level frameworks and the .NET Framework XMLs take precedence (which is unfortunate). What to do about this? @evgenyfedorov2
@huangmin-ms In your image in this comment, what folder do you have open? Do I have access to that?
There was a problem hiding this comment.
Not sure why an internal sealed class was documenting in the xml, is it expected?
Yes, it's expected that csc.exe includes non-public APIs in the documentation XML file. See https://stackoverflow.com/questions/14786930/why-does-c-sharp-compiler-includes-non-public-members-in-the-xml-documentation.
There was a problem hiding this comment.
@huangmin-ms In your image in this comment, what folder do you have open? Do I have access to that?
Send you instructions via Teams.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Learn Build status updates of commit 1ed86ec:
|
First commit - API updates
Second commit - doc updates
Fixes #9989.