Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AggregateException.xml #10396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Update AggregateException.xml #10396

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6d7e9
Update AggregateException.xml
epsitec Sep 13, 2024
4f513d6
Update xml/System/AggregateException.xml
epsitec Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/System/AggregateException.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,8 +682,8 @@
</ReturnValue>
<Parameters />
<Docs>
<summary>Returns the <see cref="T:System.AggregateException" /> that is the root cause of this exception.</summary>
<returns>The <see cref="T:System.AggregateException" /> that is the root cause of this exception.</returns>
<summary>Returns the <see cref="Exception"/> that is the root cause of this exception. This will either be the root exception, or the first <see cref="AggregateException"/> that contains either multiple inner exceptions or no inner exceptions at all.</summary>
epsitec marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in dotnet/runtime#107743 (comment) : It is not clear what "root exception" means here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkotas how would you make this clearer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion

<returns>The <see cref="T:System.Exception" /> that is the root cause of this exception.</returns>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down