Fix Encoding.GetChars
return value
#9087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Encoding.GetChars(ReadOnlySpan<Byte>, Span<Char>)
returns the number of written chars, not the number of decoded bytes as currently documented.See the default implementation, which delegates to the
GetChars(Byte*, Int32, Char*, Int32)
overload.I used the same text as in
Decoder.GetChars(ReadOnlySpan<Byte>, Span<Char>, Boolean)
.