Cosmos: Instance can be null for member translation (#23204)

Static methods
dotnet · Nov 5, 2020 · 0032742 · 0032742
1 parent 7607893
commit 0032742
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/EFCore.Cosmos/Query/Internal/CosmosMemberTranslatorProvider.cs b/src/EFCore.Cosmos/Query/Internal/CosmosMemberTranslatorProvider.cs
@@ -50,12 +50,11 @@ public CosmosMemberTranslatorProvider(
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual SqlExpression? Translate(
-            SqlExpression instance,
+            SqlExpression? instance,
             MemberInfo member,
             Type returnType,
             IDiagnosticsLogger<DbLoggerCategory.Query> logger)
         {
-            Check.NotNull(instance, nameof(instance));
             Check.NotNull(member, nameof(member));
             Check.NotNull(returnType, nameof(returnType));
             Check.NotNull(logger, nameof(logger));

diff --git a/src/EFCore.Cosmos/Query/Internal/IMemberTranslator.cs b/src/EFCore.Cosmos/Query/Internal/IMemberTranslator.cs
@@ -25,7 +25,7 @@ public interface IMemberTranslator
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         SqlExpression? Translate(
-            [NotNull] SqlExpression instance,
+            [CanBeNull] SqlExpression? instance,
             [NotNull] MemberInfo member,
             [NotNull] Type returnType,
             [NotNull] IDiagnosticsLogger<DbLoggerCategory.Query> logger);

diff --git a/src/EFCore.Cosmos/Query/Internal/IMemberTranslatorProvider.cs b/src/EFCore.Cosmos/Query/Internal/IMemberTranslatorProvider.cs
@@ -25,7 +25,7 @@ public interface IMemberTranslatorProvider
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         SqlExpression? Translate(
-            [NotNull] SqlExpression instance,
+            [CanBeNull] SqlExpression? instance,
             [NotNull] MemberInfo member,
             [NotNull] Type returnType,
             [NotNull] IDiagnosticsLogger<DbLoggerCategory.Query> logger);