Be consistent about OnModelCreating as the terminology for fluent API

Use "navigation" rather than "navigation property"
Check usage of {foreignKey} and for correct quoting and use foreignKeyProperties where appropriate
Fix AnnotationNotFound, BadFilterDerivedType, CircularDependency
Update DisplayName for shared-type entity types to include the entity type name

Part of #7201
Fixes #22310

src/EFCore.Cosmos/Properties/CosmosStrings.resx

@@ -175,7 +175,7 @@
     <value>There is no string-based representation of this query as it's executed using 'ReadItemQueryAsync({resourceId}, {partitionKey})'.</value>
   </data>
   <data name="NullTypeMappingInSqlTree" xml:space="preserve">
-    <value>Null TypeMapping in Sql Tree.</value>
+    <value>Null TypeMapping in SQL tree.</value>
   </data>
   <data name="OffsetRequiresLimit" xml:space="preserve">
     <value>Offset is not supported without Limit.</value>

src/EFCore.Design/Properties/DesignStrings.resx

@@ -196,7 +196,7 @@
     <value>Could not scaffold the foreign key '{foreignKeyName}'. The referenced table could not be found. This most likely occurred because the referenced table was excluded from scaffolding.</value>
   </data>
   <data name="ForeignKeyScaffoldErrorPrincipalTableScaffoldingError" xml:space="preserve">
-    <value>Could not scaffold the foreign key '{foreignKeyName}'. The referenced table '{principaltableName}' could not be scaffolded.</value>
+    <value>Could not scaffold the foreign key '{foreignKeyName}'. The referenced table '{principalTableName}' could not be scaffolded.</value>
   </data>
   <data name="ForeignKeyScaffoldErrorPropertyNotFound" xml:space="preserve">
     <value>Could not scaffold the foreign key '{foreignKeyName}'.  The following columns in the foreign key could not be scaffolded: {columnNames}.</value>

src/EFCore.Relational/Extensions/Internal/TupleExtensions.cs

@@ -24,7 +24,7 @@ public static class TupleExtensions
         /// </summary>
         public static string FormatTables([NotNull] this IEnumerable<(string Table, string Schema)> tables)
             => "{"
-                + string.Join(", ", tables.Select(FormatTable))
+                + string.Join(", ", tables.Select(t => "'" + FormatTable(t) + "'"))
                 + "}";
 
         /// <summary>
@@ -34,8 +34,6 @@ public static string FormatTables([NotNull] this IEnumerable<(string Table, stri
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public static string FormatTable(this (string Table, string Schema) table)
-            => "'"
-                + (table.Schema == null ? table.Table : table.Schema + "." + table.Table)
-                + "'";
+            => table.Schema == null ? table.Table : table.Schema + "." + table.Table;
     }
 }

src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs

@@ -2577,7 +2577,7 @@ private readonly IDictionary<ITable, DropTableOperation> _dropTableOperations
                 = new Dictionary<ITable, DropTableOperation>();
 
             private readonly IDictionary<IColumn, DropColumnOperation> _dropColumnOperations
-                = new Dictionary<IColumn, DropColumnOperation>();            
+                = new Dictionary<IColumn, DropColumnOperation>();
 
             private readonly IDictionary<DropTableOperation, ITable> _removedTables
                 = new Dictionary<DropTableOperation, ITable>();