Skip to content

Commit

Permalink
Start flowing Microsoft.NETCore.App dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
bricelam committed Aug 27, 2020
1 parent a57d2e5 commit 327deb3
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</PropertyGroup>

<PropertyGroup>
<DefaultNetCoreTargetFramework>netcoreapp5.0</DefaultNetCoreTargetFramework>
<DefaultNetCoreTargetFramework>net5.0</DefaultNetCoreTargetFramework>
</PropertyGroup>

<PropertyGroup>
Expand Down
7 changes: 7 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
<Project>
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<ItemGroup>
<FrameworkReference Update="Microsoft.NETCore.App"
Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimewinx64PackageVersion)"
TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)" />
</ItemGroup>
</Project>
8 changes: 8 additions & 0 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>ba5b5d18915eb637e53719373b857a2a310c204f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Ref" Version="5.0.0-rc.1.20427.3">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>ba5b5d18915eb637e53719373b857a2a310c204f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="5.0.0-rc.1.20427.3">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>ba5b5d18915eb637e53719373b857a2a310c204f</Sha>
</Dependency>
<Dependency Name="System.Collections.Immutable" Version="5.0.0-rc.1.20427.3">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>ba5b5d18915eb637e53719373b857a2a310c204f</Sha>
Expand Down
2 changes: 2 additions & 0 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
<MicrosoftExtensionsDependencyModelVersion>5.0.0-rc.1.20427.3</MicrosoftExtensionsDependencyModelVersion>
<MicrosoftExtensionsHostFactoryResolverSourcesVersion>5.0.0-rc.1.20427.3</MicrosoftExtensionsHostFactoryResolverSourcesVersion>
<MicrosoftExtensionsLoggingVersion>5.0.0-rc.1.20427.3</MicrosoftExtensionsLoggingVersion>
<MicrosoftNETCoreAppRefPackageVersion>5.0.0-rc.1.20427.3</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftNETCoreAppRuntimewinx64PackageVersion>5.0.0-rc.1.20427.3</MicrosoftNETCoreAppRuntimewinx64PackageVersion>
</PropertyGroup>
<PropertyGroup Label="Other dependencies">
<MicrosoftCodeAnalysisVersion>3.7.0</MicrosoftCodeAnalysisVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/helix.proj
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

<PropertyGroup>
<HelixPreCommands Condition = "'$(HelixTargetQueue.StartsWith(`Windows`))'">$(HelixPreCommands); SqlLocalDB start</HelixPreCommands>
<XUnitPublishTargetFramework>netcoreapp5.0</XUnitPublishTargetFramework>
<XUnitPublishTargetFramework>net5.0</XUnitPublishTargetFramework>
<XUnitRuntimeTargetFramework>netcoreapp2.0</XUnitRuntimeTargetFramework>
<XUnitRunnerVersion>2.4.1</XUnitRunnerVersion>
<XUnitArguments></XUnitArguments>
Expand Down
1 change: 1 addition & 0 deletions global.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"dotnet": "5.0.100-preview.8.20417.9",
"runtimes": {
"dotnet": [
"$(MicrosoftNETCoreAppRuntimewinx64PackageVersion)",
"3.1.7"
],
"aspnetcore": [
Expand Down

0 comments on commit 327deb3

Please sign in to comment.