Query: Avoid potential null to bool cast

Resolves #20498 Manually tested in debugger. Cannot write a test since LINQ Where requires bool and does not accept bool?
dotnet · Apr 2, 2020 · 5d15579 · 5d15579
1 parent 2aaaa35
commit 5d15579
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/EFCore.Cosmos/Query/Internal/SelectExpression.cs b/src/EFCore.Cosmos/Query/Internal/SelectExpression.cs
@@ -252,7 +252,7 @@ public virtual void ClearOrdering()
         public virtual void ApplyPredicate([NotNull] SqlExpression expression)
         {
             if (expression is SqlConstantExpression sqlConstant
-                && (bool)sqlConstant.Value)
+                && sqlConstant.Value is bool)
             {
                 return;
             }

diff --git a/src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs b/src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs
@@ -230,7 +230,7 @@ public void ApplyPredicate([NotNull] SqlExpression expression)
             Check.NotNull(expression, nameof(expression));
 
             if (expression is SqlConstantExpression sqlConstant
-                && (bool)sqlConstant.Value)
+                && sqlConstant.Value is bool)
             {
                 return;
             }