Enable NetAnalyzers reliability and globalization rules (#22625)

The following rules led to code changes:

- CA2000: Dispose objects before losing scope
- CA2012: Use ValueTasks correctly
- CA2008: Do not create tasks without passing a TaskScheduler
- CA2016: Forward the 'CancellationToken' parameter to methods that take one
- CA1310: Specify StringComparison for correctness
- CA1309: Use ordinal stringcomparison
- CA1304: Specify CultureInfo

Part of #18870

rulesets/FxCop.ruleset

@@ -95,7 +95,7 @@
       <Rule Id="CA1829" Action="None" />             <!-- Use Length/Count property instead of Count() when available -->
       <Rule Id="CA2000" Action="None" />             <!-- Dispose objects before losing scope -->
       <Rule Id="CA2002" Action="None" />             <!-- Do not lock on objects with weak identity -->
-      <Rule Id="CA2007" Action="Warning" />          <!-- Consider calling ConfigureAwait on the awaited task -->
+      <Rule Id="CA2007" Action="None" />             <!-- Consider calling ConfigureAwait on the awaited task -->
       <Rule Id="CA2008" Action="None" />             <!-- Do not create tasks without passing a TaskScheduler -->
       <Rule Id="CA2009" Action="None" />             <!-- Do not call ToImmutableCollection on an ImmutableCollection value -->
       <Rule Id="CA2010" Action="None" />             <!-- Always consume the value returned by methods marked with PreserveSigAttribute -->

src/.editorconfig

@@ -0,0 +1,68 @@
+# Code analysis rules and configuration
+
+root = false
+
+# Code files
+[*.cs]
+
+# Globalization rules
+
+# CA1303: Do not pass literals as localized parameters
+dotnet_diagnostic.CA1303.severity = none
+
+# CA1304: Specify CultureInfo
+dotnet_diagnostic.CA1304.severity = error
+
+# CA1305: Specify IFormatProvider
+dotnet_diagnostic.CA1305.severity = none
+
+# CA1307: Specify StringComparison for clarity
+dotnet_diagnostic.CA1307.severity = none
+
+# CA1308: Normalize strings to uppercase
+dotnet_diagnostic.CA1308.severity = none
+
+# CA1309: Use ordinal stringcomparison
+dotnet_diagnostic.CA1309.severity = error
+
+# CA1310: Specify StringComparison for correctness
+dotnet_diagnostic.CA1310.severity = error
+
+# CA2101: Specify marshaling for P/Invoke string arguments
+dotnet_diagnostic.CA2101.severity = error
+
+# Reliability Rules
+
+# CA2000: Dispose objects before losing scope
+# Not reliable enough - false positives
+dotnet_diagnostic.CA2000.severity = suggestion
+
+# CA2002: Do not lock on objects with weak identity
+dotnet_diagnostic.CA2002.severity = error
+
+# CA2007: Consider calling ConfigureAwait on the awaited task
+dotnet_diagnostic.CA2007.severity = error
+
+# CA2008: Do not create tasks without passing a TaskScheduler
+dotnet_diagnostic.CA2008.severity = error
+
+# CA2009: Do not call ToImmutableCollection on an ImmutableCollection value
+dotnet_diagnostic.CA2009.severity = error
+
+# CA2011: Avoid infinite recursion
+dotnet_diagnostic.CA2011.severity = error
+
+# CA2012: Use ValueTasks correctly
+dotnet_diagnostic.CA2012.severity = error
+
+# CA2013: Do not use ReferenceEquals with value types
+dotnet_diagnostic.CA2013.severity = error
+
+# CA2014: Do not use stackalloc in loops
+dotnet_diagnostic.CA2014.severity = error
+
+# CA2015: Do not define finalizers for types derived from MemoryManager<T>
+dotnet_diagnostic.CA2015.severity = error
+
+# CA2016: Forward the 'CancellationToken' parameter to methods that take one
+dotnet_diagnostic.CA2016.severity = error

src/Directory.Build.props

@@ -2,6 +2,7 @@
   <Import Project="..\Directory.Build.props" />
 
   <PropertyGroup>
+    <AnalysisLevel>latest</AnalysisLevel>
     <IsPackable>True</IsPackable>
     <IncludeSymbols>True</IncludeSymbols>
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\rulesets\EFCore.ruleset</CodeAnalysisRuleSet>

src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs

@@ -325,7 +325,7 @@ private static bool IsInInternalNamespace(ISymbol symbol)
         {
             if (symbol?.ContainingNamespace?.ToDisplayString() is string ns)
             {
-                var i = ns.IndexOf("EntityFrameworkCore");
+                var i = ns.IndexOf("EntityFrameworkCore", StringComparison.Ordinal);
 
                 return
                     i != -1

src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs

@@ -1159,7 +1159,8 @@ Expression GetPartitionKeyValue(BinaryExpression binaryExpression, IEntityType e
 
                     if (valueExpression is ConstantExpression
                         || (valueExpression is ParameterExpression valueParameterExpression
-                            && valueParameterExpression.Name?.StartsWith(QueryCompilationContext.QueryParameterPrefix) == true))
+                            && valueParameterExpression.Name?
+                                .StartsWith(QueryCompilationContext.QueryParameterPrefix, StringComparison.Ordinal) == true))
                     {
                         return valueExpression;
                     }

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs

@@ -252,9 +252,12 @@ public async ValueTask<bool> MoveNextAsync()
 
                 public ValueTask DisposeAsync()
                 {
-                    _enumerator?.DisposeAsync();
-                    _enumerator = null;
-
+                    var enumerator = _enumerator;
+                    if (enumerator != null)
+                    {
+                        _enumerator = null;
+                        return enumerator.DisposeAsync();
+                    }
                     return default;
                 }
             }

src/EFCore.Cosmos/Query/Internal/KeyAccessExpression.cs

@@ -122,7 +122,7 @@ public override bool Equals(object obj)
 
         private bool Equals(KeyAccessExpression keyAccessExpression)
             => base.Equals(keyAccessExpression)
-                && string.Equals(Name, keyAccessExpression.Name)
+                && Name == keyAccessExpression.Name
                 && AccessExpression.Equals(keyAccessExpression.AccessExpression);
 
         /// <summary>

src/EFCore.Cosmos/Query/Internal/ProjectionExpression.cs

@@ -107,8 +107,7 @@ void IPrintableExpression.Print(ExpressionPrinter expressionPrinter)
             Check.NotNull(expressionPrinter, nameof(expressionPrinter));
 
             expressionPrinter.Visit(Expression);
-            if (!string.Equals(string.Empty, Alias)
-                && !string.Equals(Alias, Name))
+            if (Alias != string.Empty && Alias != Name)
             {
                 expressionPrinter.Append(" AS " + Alias);
             }
@@ -127,7 +126,7 @@ public override bool Equals(object obj)
                     && Equals(projectionExpression));
 
         private bool Equals(ProjectionExpression projectionExpression)
-            => string.Equals(Alias, projectionExpression.Alias)
+            => Alias == projectionExpression.Alias
                 && Expression.Equals(projectionExpression.Expression);
 
         /// <summary>

src/EFCore.Cosmos/Query/Internal/RootReferenceExpression.cs

@@ -107,7 +107,7 @@ public override bool Equals(object obj)
                     && Equals(rootReferenceExpression));
 
         private bool Equals(RootReferenceExpression rootReferenceExpression)
-            => string.Equals(Alias, rootReferenceExpression.Alias)
+            => Alias == rootReferenceExpression.Alias
                 && EntityType.Equals(rootReferenceExpression.EntityType);
 
         /// <summary>

src/EFCore.Cosmos/Query/Internal/SqlFunctionExpression.cs

@@ -134,7 +134,7 @@ public override bool Equals(object obj)
 
         private bool Equals(SqlFunctionExpression sqlFunctionExpression)
             => base.Equals(sqlFunctionExpression)
-                && string.Equals(Name, sqlFunctionExpression.Name)
+                && Name == sqlFunctionExpression.Name
                 && Arguments.SequenceEqual(sqlFunctionExpression.Arguments);
 
         /// <summary>

src/EFCore.Cosmos/Query/Internal/SqlParameterExpression.cs

@@ -89,8 +89,7 @@ public override bool Equals(object obj)
                     && Equals(sqlParameterExpression));
 
         private bool Equals(SqlParameterExpression sqlParameterExpression)
-            => base.Equals(sqlParameterExpression)
-                && string.Equals(Name, sqlParameterExpression.Name);
+            => base.Equals(sqlParameterExpression) && Name != sqlParameterExpression.Name;
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to

src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs

@@ -565,8 +565,8 @@ private static JObject JObjectFromReadItemResponseMessage(ResponseMessage respon
             responseMessage.EnsureSuccessStatusCode();
 
             var responseStream = responseMessage.Content;
-            var reader = new StreamReader(responseStream);
-            var jsonReader = new JsonTextReader(reader);
+            using var reader = new StreamReader(responseStream);
+            using var jsonReader = new JsonTextReader(reader);
 
             var jObject = Serializer.Deserialize<JObject>(jsonReader);
 

src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs

@@ -942,14 +942,12 @@ private static bool EntityTypePathEquals(IEntityType source, IEntityType target,
                 return true;
             }
 
-            if (!string.Equals(source.Name, target.Name))
+            if (source.Name != target.Name)
             {
                 return false;
             }
 
-            if (!string.Equals(
-                GetDefiningNavigationName(source),
-                GetDefiningNavigationName(target)))
+            if (GetDefiningNavigationName(source) != GetDefiningNavigationName(target))
             {
                 return false;
             }

src/EFCore.Relational/Query/QuerySqlGenerator.cs

@@ -249,9 +249,8 @@ protected override Expression VisitProjection(ProjectionExpression projectionExp
 
             Visit(projectionExpression.Expression);
 
-            if (!string.Equals(string.Empty, projectionExpression.Alias)
-                && !(projectionExpression.Expression is ColumnExpression column
-                    && string.Equals(column.Name, projectionExpression.Alias)))
+            if (projectionExpression.Alias != string.Empty
+                && !(projectionExpression.Expression is ColumnExpression column && column.Name == projectionExpression.Alias))
             {
                 _relationalCommandBuilder.Append(AliasSeparator + _sqlGenerationHelper.DelimitIdentifier(projectionExpression.Alias));
             }

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs

@@ -93,7 +93,7 @@ protected override Expression VisitExtension(Expression extensionExpression)
                             fromSqlQueryRootExpression.EntityType,
                             new FromSqlExpression(
                                 fromSqlQueryRootExpression.EntityType.GetDefaultMappings().SingleOrDefault().Table.Name.Substring(0, 1)
-                                    .ToLower(),
+                                    .ToLowerInvariant(),
                                 fromSqlQueryRootExpression.Sql,
                                 fromSqlQueryRootExpression.Argument)));
 
@@ -1461,7 +1461,7 @@ private static IDictionary<IProperty, ColumnExpression> GetPropertyExpressionFro
                         tableExpression = selectExpression.Tables
                             .Select(t => (t as InnerJoinExpression)?.Table ?? (t as LeftJoinExpression)?.Table ?? t)
                             .Cast<TableExpression>()
-                            .First(t => string.Equals(t.Name, table.Name) && string.Equals(t.Schema, table.Schema));
+                            .First(t => t.Name == table.Name && t.Schema == table.Schema);
                     }
 
                     var propertyExpressions = new Dictionary<IProperty, ColumnExpression>();

src/EFCore.Relational/Query/SqlExpressionFactory.cs

@@ -817,7 +817,7 @@ public virtual SelectExpression Select(IEntityType entityType, string sql, Expre
             Check.NotNull(sql, nameof(sql));
 
             var tableExpression = new FromSqlExpression(
-                entityType.GetDefaultMappings().SingleOrDefault().Table.Name.Substring(0, 1).ToLower(), sql, sqlArguments);
+                entityType.GetDefaultMappings().SingleOrDefault().Table.Name.Substring(0, 1).ToLowerInvariant(), sql, sqlArguments);
             var selectExpression = new SelectExpression(entityType, tableExpression);
             AddConditions(selectExpression, entityType);
 

src/EFCore.Relational/Query/SqlExpressions/ColumnExpression.cs

@@ -114,7 +114,7 @@ public override bool Equals(object obj)
 
         private bool Equals(ColumnExpression columnExpression)
             => base.Equals(columnExpression)
-                && string.Equals(Name, columnExpression.Name)
+                && Name == columnExpression.Name
                 && Table.Equals(columnExpression.Table)
                 && IsNullable == columnExpression.IsNullable;
 

src/EFCore.Relational/Query/SqlExpressions/FromSqlExpression.cs

@@ -102,7 +102,7 @@ public override bool Equals(object obj)
 
         private bool Equals(FromSqlExpression fromSqlExpression)
             => base.Equals(fromSqlExpression)
-                && string.Equals(Sql, fromSqlExpression.Sql)
+                && Sql == fromSqlExpression.Sql
                 && ExpressionEqualityComparer.Instance.Equals(Arguments, fromSqlExpression.Arguments);
 
         /// <inheritdoc />

src/EFCore.Relational/Query/SqlExpressions/ProjectionExpression.cs

@@ -76,9 +76,9 @@ void IPrintableExpression.Print(ExpressionPrinter expressionPrinter)
             Check.NotNull(expressionPrinter, nameof(expressionPrinter));
 
             expressionPrinter.Visit(Expression);
-            if (!string.Equals(string.Empty, Alias)
+            if (Alias != string.Empty
                 && !(Expression is ColumnExpression column
-                    && string.Equals(column.Name, Alias)))
+                    && column.Name == Alias))
             {
                 expressionPrinter.Append(" AS " + Alias);
             }
@@ -92,8 +92,7 @@ public override bool Equals(object obj)
                     && Equals(projectionExpression));
 
         private bool Equals(ProjectionExpression projectionExpression)
-            => string.Equals(Alias, projectionExpression.Alias)
-                && Expression.Equals(projectionExpression.Expression);
+            => Alias == projectionExpression.Alias && Expression.Equals(projectionExpression.Expression);
 
         /// <inheritdoc />
         public override int GetHashCode()

src/EFCore.Relational/Query/SqlExpressions/SqlFragmentExpression.cs

@@ -61,8 +61,8 @@ public override bool Equals(object obj)
 
         private bool Equals(SqlFragmentExpression sqlFragmentExpression)
             => base.Equals(sqlFragmentExpression)
-                && string.Equals(Sql, sqlFragmentExpression.Sql)
-                && !string.Equals(Sql, "*"); // We make star projection different because it could be coming from different table.
+                && Sql == sqlFragmentExpression.Sql
+                && Sql != "*"; // We make star projection different because it could be coming from different table.
 
         /// <inheritdoc />
         public override int GetHashCode()

src/EFCore.Relational/Query/SqlExpressions/SqlFunctionExpression.cs

@@ -379,8 +379,8 @@ public override bool Equals(object obj)
 
         private bool Equals(SqlFunctionExpression sqlFunctionExpression)
             => base.Equals(sqlFunctionExpression)
-                && string.Equals(Name, sqlFunctionExpression.Name)
-                && string.Equals(Schema, sqlFunctionExpression.Schema)
+                && Name == sqlFunctionExpression.Name
+                && Schema == sqlFunctionExpression.Schema
                 && ((Instance == null && sqlFunctionExpression.Instance == null)
                     || (Instance != null && Instance.Equals(sqlFunctionExpression.Instance)))
                 && Arguments.SequenceEqual(sqlFunctionExpression.Arguments);

src/EFCore.Relational/Query/SqlExpressions/SqlParameterExpression.cs

@@ -74,7 +74,7 @@ public override bool Equals(object obj)
 
         private bool Equals(SqlParameterExpression sqlParameterExpression)
             => base.Equals(sqlParameterExpression)
-                && string.Equals(Name, sqlParameterExpression.Name);
+                && Name == sqlParameterExpression.Name;
 
         /// <inheritdoc />
         public override int GetHashCode()

src/EFCore.Relational/Query/SqlExpressions/TableExpression.cs

@@ -21,7 +21,7 @@ namespace Microsoft.EntityFrameworkCore.Query.SqlExpressions
     public sealed class TableExpression : TableExpressionBase
     {
         internal TableExpression([NotNull] ITableBase table)
-            : base(table.Name.Substring(0, 1).ToLower())
+            : base(table.Name.Substring(0, 1).ToLowerInvariant())
         {
             Name = table.Name;
             Schema = table.Schema;

src/EFCore.Relational/Query/SqlExpressions/TableExpressionBase.cs

@@ -69,7 +69,7 @@ public override bool Equals(object obj)
                     && Equals(tableExpressionBase));
 
         private bool Equals(TableExpressionBase tableExpressionBase)
-            => string.Equals(Alias, tableExpressionBase.Alias);
+            => Alias == tableExpressionBase.Alias;
 
         /// <inheritdoc />
         public override int GetHashCode()