Re-enable tests for issue#16057

Let's see if we still have discrepancies Resolves #16057
dotnet · Aug 28, 2020 · a89e329 · a89e329
1 parent a29f30c
commit a89e329
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 18 deletions.
diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
@@ -2422,11 +2422,12 @@ public override async Task Where_datetimeoffset_date_component(bool async)
         {
             await base.Where_datetimeoffset_date_component(async);
 
-            // issue #16057
-            //            AssertSql(
-            //                @"SELECT [m].[Id], [m].[CodeName], [m].[Rating], [m].[Timeline]
-            //FROM [Missions] AS [m]
-            //WHERE CONVERT(date, [m].[Timeline]) > '0001-01-01T00:00:00.0000000-08:00'");
+            AssertSql(
+                @"@__Date_0='0001-01-01T00:00:00.0000000'
+
+SELECT [m].[Id], [m].[CodeName], [m].[Duration], [m].[Rating], [m].[Timeline]
+FROM [Missions] AS [m]
+WHERE CONVERT(date, [m].[Timeline]) > @__Date_0");
         }
 
         public override async Task Where_datetimeoffset_year_component(bool async)

diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/QueryBugsTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/QueryBugsTest.cs
@@ -840,14 +840,13 @@ private void Execute1742(CustomerDetails_1742 details)
                 var firstName = details.FirstName;
                 ctx.Customers.Where(c => c.FirstName == firstName && c.LastName == details.LastName).ToList();
 
-                // issue #16057
-                //                    AssertSql(
-                //                        @"@__firstName_0='Foo' (Size = 450)
-                //@__8__locals1_details_LastName_1='Bar' (Size = 450)
-
-                //SELECT [c].[FirstName], [c].[LastName]
-                //FROM [Customer] AS [c]
-                //WHERE (([c].[FirstName] = @__firstName_0) AND @__firstName_0 IS NOT NULL) AND (([c].[LastName] = @__8__locals1_details_LastName_1) AND @__8__locals1_details_LastName_1 IS NOT NULL)");
+            AssertSql(
+                @"@__firstName_0='Foo' (Size = 450)
+@__8__locals1_details_LastName_1='Bar' (Size = 450)
+
+SELECT [c].[FirstName], [c].[LastName]
+FROM [Customer] AS [c]
+WHERE ([c].[FirstName] = @__firstName_0) AND ([c].[LastName] = @__8__locals1_details_LastName_1)");
             }
         }
 

diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs
@@ -2896,11 +2896,12 @@ public override async Task Where_datetimeoffset_date_component(bool async)
         {
             await base.Where_datetimeoffset_date_component(async);
 
-            // issue #16057
-            //            AssertSql(
-            //                @"SELECT [m].[Id], [m].[CodeName], [m].[Rating], [m].[Timeline]
-            //FROM [Missions] AS [m]
-            //WHERE CONVERT(date, [m].[Timeline]) > '0001-01-01T00:00:00.0000000-08:00'");
+            AssertSql(
+                @"@__Date_0='0001-01-01T00:00:00.0000000'
+
+SELECT [m].[Id], [m].[CodeName], [m].[Duration], [m].[Rating], [m].[Timeline]
+FROM [Missions] AS [m]
+WHERE CONVERT(date, [m].[Timeline]) > @__Date_0");
         }
 
         public override async Task Where_datetimeoffset_year_component(bool async)