Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueConverter expressions: Are you really lazy? #13844

Closed
smitpatel opened this issue Oct 31, 2018 · 1 comment · Fixed by #19406
Closed

ValueConverter expressions: Are you really lazy? #13844

smitpatel opened this issue Oct 31, 2018 · 1 comment · Fixed by #19406
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

https://github.com/aspnet/EntityFrameworkCore/blob/4f470638e0e98a8c60175c524e99792a72640986/src/EFCore/Storage/ValueConversion/ValueConverter%60.cs#L61-L71

ctor initializes them already.
@ajcvickers
Copy link
Member

Looks like constructor is wrong here, but I guess we could go either way.

@divega divega added this to the 3.0.0 milestone Nov 2, 2018
@roji roji mentioned this issue Jan 18, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 13, 2019
ajcvickers added a commit that referenced this issue Dec 26, 2019
@ajcvickers
Value converters grooving on a rainy day...
d076029 
Fixes #13844
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 26, 2019
@ajcvickers ajcvickers mentioned this issue Dec 26, 2019
Merged
ajcvickers added a commit that referenced this issue Dec 26, 2019
@ajcvickers
Value converters grooving on a rainy day...
6ff8377 
Fixes #13844
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Value converters grooving on a rainy day... dotnet/efcore
3 participants
@divega @ajcvickers @smitpatel