Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: some literals are not translated #16919

Closed
AndriySvyryd opened this issue Aug 2, 2019 · 1 comment · Fixed by #23213
Closed

Cosmos: some literals are not translated #16919

AndriySvyryd opened this issue Aug 2, 2019 · 1 comment · Fixed by #23213
Assignees
@smitpatel
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 2, 2019 •
edited
Loading

In particular enums. See BuiltInDataTypesCosmosTest and CustomConvertersCosmosTest
@AndriySvyryd AndriySvyryd self-assigned this Aug 2, 2019
@ajcvickers
Copy link
Member

@AndriySvyryd 3.0?

@AndriySvyryd AndriySvyryd added this to the 3.0.0 milestone Aug 5, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Aug 14, 2019
Merged
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Aug 14, 2019
@dvoreckyaa dvoreckyaa mentioned this issue May 5, 2020
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel assigned smitpatel and unassigned AndriySvyryd Nov 6, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 6, 2020
smitpatel added a commit that referenced this issue Nov 6, 2020
@smitpatel
Cosmos: Add support for char literals
6b36a49 
Also remove implicit convert for float to double since there is no explicit convert in Cosmos

Resolves #16919
@smitpatel smitpatel mentioned this issue Nov 6, 2020
Merged
@ghost ghost closed this as completed in #23213 Nov 6, 2020
ghost pushed a commit that referenced this issue Nov 6, 2020
@smitpatel
Cosmos: Add support for char literals (#23213)
b66097c 
Also remove implicit convert for float to double since there is no explicit convert in Cosmos

Resolves #16919
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos: Add support for char literals dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd