Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fluent API for IDENTITY seed and increment #16922

Closed
bricelam opened this issue Aug 2, 2019 · 5 comments
Closed

Generate fluent API for IDENTITY seed and increment #16922

bricelam opened this issue Aug 2, 2019 · 5 comments
Assignees
Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Aug 2, 2019

Some questions that have come up:

  • What happens in migrations when you change the seed or increment values?
  • Does the model snapshot call the fluent API?
  • Should the two model annotations be consolidated into one?
@ajcvickers
Copy link
Member

@bricelam

What happens in migrations when you change the seed or increment values?

What do we do for sequences?

Does the model snapshot call the fluent API?

We can do this later without it being breaking, right?

Should the two model annotations be consolidated into one?

Seems like you did this in the PR, or is this something different?

@bricelam
Copy link
Contributor Author

bricelam commented Aug 3, 2019

What happens in migrations when you change the seed or increment values?

What do we do for sequences?

There is SQL to alter and reset them.

Does the model snapshot call the fluent API?

We can do this later without it being breaking, right?

Yes, but we’ll have to special case the existing annotations forevermore

Should the two model annotations be consolidated into one?

Seems like you did this in the PR, or is this something different?

I only did it in Migration operations, we could do the same in the model

@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 5, 2019
@ajcvickers ajcvickers changed the title Review the IDENTITY seed and increment implementation Generate fluent API for IDENTITY seed and increment Aug 5, 2019
@ajcvickers
Copy link
Member

Split out #16964 and #16965 to backlog; leaving this in 3.0.

@bricelam
Copy link
Contributor Author

Looks like we haven't yet provided a hook for providers to handle annotations in the model snapshot.

@lajones
Copy link
Contributor

lajones commented Apr 28, 2020

Poaching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants