Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please add feature DateDiffWeek extension for mssql #17170

Closed
WeihanLi opened this issue Aug 15, 2019 · 5 comments
Closed

please add feature DateDiffWeek extension for mssql #17170

WeihanLi opened this issue Aug 15, 2019 · 5 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
5.0.0

Comments

@WeihanLi
Copy link
Contributor

WeihanLi commented Aug 15, 2019 •
edited
Loading

Please add feature DateDiffWeek DbFunctions extension for mssql

https://github.com/aspnet/EntityFrameworkCore/blob/release/3.0/src/EFCore.SqlServer/Extensions/SqlServerDbFunctionsExtensions.cs
https://docs.microsoft.com/en-us/sql/t-sql/functions/datediff-transact-sql?view=sql-server-2017
@ajcvickers ajcvickers added this to the Backlog milestone Aug 16, 2019
@ajcvickers ajcvickers added good first issue This issue should be relatively straightforward to fix. type-enhancement labels Aug 16, 2019
@ralmsdeveloper
Copy link
Contributor

@ajcvickers

can i pull this for me?

@ajcvickers
Copy link
Member

@ralmsdeveloper Go for it, but keep in mind that it won't be included in 3.0 (closing down) or 3.1 (new features are not allowed 🤷‍♂).

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 17, 2019 •
edited
Loading

No new features in 3.1 ??

ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Aug 17, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
cda8acd
@ralmsdeveloper ralmsdeveloper mentioned this issue Aug 17, 2019
Closed
ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Aug 18, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
20146db
ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Aug 18, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
245ce03
ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Aug 18, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
8a98a15
ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Aug 18, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
badf500
ralmsdeveloper added a commit to ralmsdeveloper/EntityFrameworkCore that referenced this issue Sep 5, 2019
@ralmsdeveloper
dotnet#17170 - DATEDIFF Week Implementation
3de2288
smitpatel pushed a commit that referenced this issue Sep 9, 2019
@ralmsdeveloper @smitpatel
Resolves #17170
20542ad
@smitpatel smitpatel modified the milestones: Backlog, 3.1.0 Sep 9, 2019
@smitpatel smitpatel self-assigned this Sep 9, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 9, 2019
smitpatel pushed a commit that referenced this issue Sep 9, 2019
@ralmsdeveloper @smitpatel
SqlServer: Implement DateDiffWeek
3ddb4fb 
Resolves #17170
smitpatel pushed a commit that referenced this issue Sep 9, 2019
@ralmsdeveloper @smitpatel
SqlServer: Implement DateDiffWeek
84b6414 
Resolves #17170
smitpatel pushed a commit that referenced this issue Sep 12, 2019
@ralmsdeveloper @smitpatel
SqlServer: Implement DateDiffWeek
11a14c4 
Resolves #17170
@smitpatel smitpatel mentioned this issue Sep 12, 2019
Merged
smitpatel pushed a commit that referenced this issue Sep 12, 2019
@ralmsdeveloper @smitpatel
SqlServer: Implement DateDiffWeek
1d91689 
Resolves #17170
@smitpatel smitpatel modified the milestones: 3.1.0, Backlog Sep 12, 2019
@bricelam bricelam modified the milestones: Backlog, 5.0.0 Sep 18, 2019
@arek-avanade
Copy link

@bricelam Is this going to be included in EF Core 5? Why so late?

@bricelam
Copy link
Contributor

bricelam commented Jan 9, 2020 •
edited by AndriySvyryd
Loading

EF Core 5 is the next release after 3.1

@ajcvickers ajcvickers mentioned this issue Jan 30, 2020
Closed
13 tasks
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
7 participants
@bricelam @ajcvickers @smitpatel @ErikEJ @WeihanLi @ralmsdeveloper @arek-avanade