Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that the metadata API is consistent #17360

Closed
AndriySvyryd opened this issue Aug 21, 2019 · 0 comments · Fixed by #20267
Closed

Make sure that the metadata API is consistent #17360

AndriySvyryd opened this issue Aug 21, 2019 · 0 comments · Fixed by #20267
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware punted-for-3.1 type-cleanup
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 21, 2019 •
edited
Loading

  • All mutating methods should have a bool fromDataAnnotation = false parameter
  • All mutable facets should have a corresponding Get*ConfigurationSource() method on IConvention
  • All mutable facets should have a corresponding CanSet*() method on IConventionBuilder
  • Fluent API can only be prefixed by "Has", "HasNo", "To", "Is". Metadata API can only be prefixed by "Add", "Remove", "Get", "Is"
  • Provider-specific extensions should have matching IModel and IMutable methods
  • Set* methods on IMutable types should return void and on IConvention should return the configured value
  • Remove* methods on IMutable and IConvention type should return the removed value
@ajcvickers ajcvickers added this to the 3.1.0 milestone Aug 23, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
AndriySvyryd added a commit that referenced this issue Nov 2, 2019
@AndriySvyryd
Test for #17360
6062764 
Fixes #17360
@AndriySvyryd AndriySvyryd changed the title Make sure that the convention metadata API is consistent Make sure that the metadata API is consistent Mar 11, 2020
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 5.0.0 Mar 11, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Mar 11, 2020
Closed
AndriySvyryd added a commit that referenced this issue Mar 12, 2020
@AndriySvyryd
Fix API consistency errors in metadata
57bc9b4 
Add more Metadatada API consistency tests
Refactor ApiConsistencyTest

Fixes #17360
@AndriySvyryd AndriySvyryd mentioned this issue Mar 12, 2020
Merged
@AndriySvyryd AndriySvyryd added providers-beware closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Mar 13, 2020
@AndriySvyryd AndriySvyryd removed their assignment Mar 13, 2020
AndriySvyryd added a commit that referenced this issue Mar 14, 2020
@AndriySvyryd
Fix API consistency errors in metadata
4e88a47 
Add more Metadatada API consistency tests
Refactor ApiConsistencyTest

Fixes #17360
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware punted-for-3.1 type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix API consistency errors in metadata dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd