-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify behavior for EnsureExists with an empty database #17563
Closed
Labels
area-docs
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
punted-for-3.1
type-enhancement
Milestone
Comments
ajcvickers
changed the title
Contradictory Statement
Clarify behavior for EnsureExists with an empty database
Sep 2, 2019
ajcvickers
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Sep 20, 2020
ajcvickers
added a commit
that referenced
this issue
Sep 20, 2020
* Document connection obtained from DatabaseFacade.GetDbConnection() should normally not be disposed Fixes #11415 * Add XML docs referencing how to determine the default CommandTimeout Fixes #17503 * Clarify behavior for EnsureExists with an empty database Fixes #17563 * A hyperlink to the DbContext.Database.Migrate() method would be useful Fixes #17571 * Default values for maxRetryCount, maxRetryDelay, and errorNumbersToAdd Fixes #17574 * Document that modifying entity states while iterating over entries can result in "Collection was modified" exception Fixes #18389 * Update API doc links to correctly reference external dependencies Fixes #18580 * Make it clearer how to access EF.Functions Fixes #21424 * Improve API docs for TrackGraph Fixes #22529
Merged
ajcvickers
added a commit
that referenced
this issue
Sep 21, 2020
* Document connection obtained from DatabaseFacade.GetDbConnection() should normally not be disposed Fixes #11415 * Add XML docs referencing how to determine the default CommandTimeout Fixes #17503 * Clarify behavior for EnsureExists with an empty database Fixes #17563 * A hyperlink to the DbContext.Database.Migrate() method would be useful Fixes #17571 * Default values for maxRetryCount, maxRetryDelay, and errorNumbersToAdd Fixes #17574 * Document that modifying entity states while iterating over entries can result in "Collection was modified" exception Fixes #18389 * Update API doc links to correctly reference external dependencies Fixes #18580 * Make it clearer how to access EF.Functions Fixes #21424 * Improve API docs for TrackGraph Fixes #22529
ajcvickers
added a commit
that referenced
this issue
Sep 24, 2020
* Update API docs * Document connection obtained from DatabaseFacade.GetDbConnection() should normally not be disposed Fixes #11415 * Add XML docs referencing how to determine the default CommandTimeout Fixes #17503 * Clarify behavior for EnsureExists with an empty database Fixes #17563 * A hyperlink to the DbContext.Database.Migrate() method would be useful Fixes #17571 * Default values for maxRetryCount, maxRetryDelay, and errorNumbersToAdd Fixes #17574 * Document that modifying entity states while iterating over entries can result in "Collection was modified" exception Fixes #18389 * Update API doc links to correctly reference external dependencies Fixes #18580 * Make it clearer how to access EF.Functions Fixes #21424 * Improve API docs for TrackGraph Fixes #22529 * Review feedback * Update src/EFCore/EF.cs Co-authored-by: Shay Rojansky <roji@roji.org> Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-docs
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
punted-for-3.1
type-enhancement
From:
> Ensures that the database for the context exists. If it exists, no action is taken. If it does not exist then the database and all its schema are created. If the database exists, then no effort is made to ensure it is compatible with the model for this context.
> If it [the database] exists, no action is taken.
> If the database exists, then no effort is made to ensure it is compatible with the model for this context.
The last quote is somewhat ambiguous, but the fact is that if the database is empty, then the tables will be created. This is in contradiction to the quote preceding it.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: